Marco Pesenti Gritti wrote: > On Fri, Jan 23, 2009 at 10:45 AM, Bernie Innocenti <ber...@codewiz.org> wrote: >> Some thoughts: >> >> - Because the commit message summary appears in the shortlog, >> it should be kept below 74 characters to avoid ugly wrapping. >> >> - Given the above, the word "Closes: " steals precious characters, >> and is rather easy to deduce, therefore I'd opt it out. >> >> - The leading dot at the end should not be included because >> it looks super ugly in the subject of an email. >> >> - To reduce clutter, I'd make the "SL" prefix implied, and leave >> other prefixes such as OLPC#123 and RH#456 explicit. >> >> Do we have a wiki page where we can document these practices? > > Perhaps http://sugarlabs.org/go/DevelopmentTeam/Git > > Marco
Thanks for all your comments. I have put up http://sugarlabs.org/go/DevelopmentTeam/Git#Git_commit_message_guidelines reflecting the discussion. Nothing set in stone yet, feel free to comment or change in the next days - otherwise it will become mandatory ;) Cheers, Simon _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
