On Mon, Aug 23, 2010 at 11:58:01AM +0200, Simon Schampijer wrote: > Hi Aleksey, > > On 08/23/2010 09:25 AM, Tomeu Vizoso wrote: > > On Sat, Aug 21, 2010 at 01:24, Aleksey Lim<alsr...@member.fsf.org> wrote: > >> Hi all, > >> > >> Implement sorting in the Journal UI. Also adds support for the two new > >> properties (filesize and ctime). > > thanks for proposing this Feature. Thanks as well to Andres for working > on it! > > I know that this Feature has a high value for learners (seen it myself > in class already - especially the addition of the creation date), so I > would not like this Feature to miss the boat. If all the issues are > addressed I would consider it. > > Remember that today is UI Freeze so it really has to be in today's > tarballs! So the reviewer has to be convinced, too. > > >> Feature page: > >> http://wiki.sugarlabs.org/go/Features/Journal_Sort > >> > >> Implementations: > >> http://git.sugarlabs.org/projects/sugar-datastore/repos/journal_sort > >> http://git.sugarlabs.org/projects/sugar/repos/journal_sort > > > > Some questions: > > > > - what with hard links? Aren't users going to expect that if they > > delete an entry of 50MB that their available space will be increased > > by 50MB? > > > > - creation time will be always displayed as '%Y-%m-%dT%H:%M:%S' ? What > > about those countries where they expect the fields being ordered in a > > different way? (may be good to format the string in listview.py > > instead of in listmodel.py, so we keep UI decisions out from the > > model). > > > > - if we are not interested in sorting by title, we should remove that > > field from the index, because makes the index bigger and also slows > > queries down a bit. > > > > - seems like this feature is still in dicussion in > > http://bugs.sugarlabs.org/ticket/1915 so I don't think it makes sense > > to accept it for inclusion in 0.90 at this stage. Also would be good > > to have the feature first accepted in the release set before > > eventually merging it. > > > > Regards, > > > > Tomeu > > Does your patch address the issue with ctime? Can the list be filtered > by creation date now? > > There are new icons as well. Is there a patch for those? > > I had the following error when running the first time: > > 1282556253.679258 DEBUG root: Updating entry > 'e603b6df-2b82-4917-8f86-c948fc4dc24f' in index. 93 to go. > 1282556253.704024 ERROR root: Error processing > 'e603b6df-2b82-4917-8f86-c948fc4dc24f' > Traceback (most recent call last): > File > "/home/erikos/sugar-jhbuild-master/install/lib/python2.6/site-packages/carquinyol/datastore.py", > > line 125, in __update_index_cb > self._index_store.store(uid, props) > File > "/home/erikos/sugar-jhbuild-master/install/lib/python2.6/site-packages/carquinyol/indexstore.py", > > line 261, in store > term_generator.index_document(document, properties) > File > "/home/erikos/sugar-jhbuild-master/install/lib/python2.6/site-packages/carquinyol/indexstore.py", > > line 75, in index_document > xapian.sortable_serialise(int(properties['filesize']))) > KeyError: 'filesize'
Andrés: It would be better to not rely on having new feilds in ds requests (sugar, that operates w/ ds, could be old and not support new fields) > I could not see any list after applying the Feature, I had the no > entries message. > > Regards, > Simon > > > -- Aleksey _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel