On 11/15/2010 01:47 AM, James Cameron wrote:
On Sun, Nov 14, 2010 at 07:35:27PM -0500, Bernie Innocenti wrote:
On Mon, 2010-11-15 at 10:22 +1100, James Cameron wrote:
On Sat, Nov 13, 2010 at 05:38:14PM +0530, shan...@seeta.in wrote:
From: Shanjit Singh Jajmann<shan...@seeta.in>
Muting by clicking on the icon is killed.
This disables unmuting as well. Hope that is what you intended.
Yes, basically we don't want mute to toggle by just clicking on the
icon. There's also a checkbox in the popup menu.
In that case the patch commit text is ambiguous. ;-)
"Remove mute toggle via frame speaker icon click."
Yes, I prefer as well the term "remove" over "kill" in commit messages.
Please reference as well the ticket if there is one at the end of the
commit message (e.g. Remove mute toggle #1234).
Regards,
Simon
_______________________________________________
Sugar-devel mailing list
Sugar-devel@lists.sugarlabs.org
http://lists.sugarlabs.org/listinfo/sugar-devel
