011/6/18 Sascha Silbe <sascha-ml-reply-to-201...@silbe.org> > > Nice idea. As for the patch, I wonder why you use different code than > what's in extensions/cpsection/aboutcomputer/model.py. I'm not sure > whether importing or copying is the better option here, but different > code altogether definitely isn't. We need to show the same value in both > the Intro and the About my Computer CP section. > > Importing extensions/cpsection/aboutcomputer/model.py has the obvious > advantage that there's no code duplication and thus no risk of diverging > code paths. The disadvantage is that the Intro would break if someone > chose not to install the About my Computer CP section. Copying the code > and adding a note to both copies that they should be kept in sync would > allow the Intro screen to be used even in absence of the About my > Computer CP section. >
I don't know why someone would chose not install "About my computer" CP Section. IMHO the best option is importing extensions/cpsection/aboutcomputer/model.py if the extension is installed, otherwise intro screen will not display build number. regards, Esteban.
_______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel
