Hi Simon, On 29 Jul 2011, at 12:10, Simon Schampijer wrote:
> On 07/28/2011 06:12 PM, Gary Martin wrote: >> Hi Simon, >> >> On 28 Jul 2011, at 12:55, Simon Schampijer wrote: >> >>> On 07/27/2011 06:00 PM, Gary Martin wrote: >>>> Hi Simon, >>>> >>>> On 27 Jul 2011, at 14:44, Simon Schampijer wrote: >>>> >>>>> On 07/27/2011 01:40 PM, Gonzalo Odiard wrote: >>>>>>> device.png (the option displayed for a a file on a external device): Do >>>>>>> we >>>>>>> display the duplicate option there as well (duplicate a file on an >>>>>>> external >>>>>>> device)? How is it colored if - black and white because it is not >>>>>>> 'owned'? >>>>>>> We miss here the Journal as an option for the file to be copied to, >>>>>>> that can >>>>>>> be added. >>>>>>> >>>>>>> >>>>>> I think is better add the Journal in the Copy to submenu when you are in >>>>>> a >>>>>> device. >>>>>> Also, probably the Clipboard should be the last option, no the first, >>>>>> >>>>>> Gonzalo >>>>>> >>>>> >>>>> I sent new mockups going back to my original design without a 'duplicate >>>>> entry'. This does 'solve' the issue you raise. >>>> >>>> FWIW I do still find 'Copy to -> Journal' confusing and unexpected. I'd >>>> certainly not look for that functionality it in the 'Copy to' sub palette, >>>> and even if I did see the Journal icon in there I would assume it was a >>>> bug (this object is already in my Journal, why would I want to copy over >>>> it). >>> >>> Ok, accepted, as you are not the only one. Let's keep the duplicate entry. >>> >>>> I'm beginning to wonder if we should just replace the activity Keep button >>>> with a Duplicate button and not try to expose it in the Journal/details >>>> view? >>> >>> Ohh no, everything but not that :-) >> >> :-) >> >>>> BTW What was wrong with adding a top-level Duplicate toolbar icon to the >>>> Details view (to match how Duplicate was at the top level of the Journal >>>> object palette)? >>> >>> Yeah, thought that as well myself this morning, attached are the new >>> screenshots. >>> >>> Some words about my decisions: >>> >>> - the duplicate option is only visible in the Journal entry palette and the >>> Journal entry detail view, not in the palette and detail view of the file >>> on the external device >>> >>> - the duplicate option is colored in the entry color as this exact entry >>> gets duplicated (in the screenshots we see two entries with different >>> colors in the same Journal and the color of the option changes >>> accordingly), I wondered if the icon itself should show actually two >>> colored objects not only one (duplication) >> >> I've had a quick look at the mockup in your more recent email, having all of >> the duplicate icon in the to be duplicated object colour does not work for >> me as a small palette icon. Better with one part in white and one in colour. >> It's visually clearer (still visible at the small size if a user has an >> unfortunate colour choice). If you think the colour metaphor is not being >> fully adhered to, think of the icon as an action in progress, part way >> through duplication ;) > > Accepted. > >>> - the copy-to Journal option in the palette of the file on the external >>> device is colored in the users color. >> >> Good (I assume you mean the copy-to --> Journal, where the Journal is in >> the users own colour as the object on the external device has no current >> metadata). > > Yes, indeed. > >> I notice in the users Journal palette that the copy-to icon is not picking >> up the object colour? Was this intended as this should be using the object >> colour in the same way as the duplicate icon. Looks like you have it >> correctly coloured in the details view toolbar. > > Done now. > >>> - for the copy-to icon I am not sure if colored or black/white makes more >>> sense, because uncertain I went for b/w >> >> Yes the copy-to icon for objects without metadata would be black& white. > > Yes, that's the case. To compare I have copied a Journal entry to the > external device. The color of the copy-to icon in the palette and detail view > is picked up. > > Are the screenshots below look good now? I would send the patches for review > then. Fab, thanks. Yes they all looked very good and in context. --Gary > Thanks a lot for the quick feedback, > Simon > > > > > <external_detail_1.png><external_detail_2.png><external_palette_1.png><external_palette_2.png><journal_detail_1.png><journal_detail_2.png><journal_palette_1.png><journal_palette_2.png> _______________________________________________ Sugar-devel mailing list [email protected] http://lists.sugarlabs.org/listinfo/sugar-devel
