On Sun, Sep 30, 2012 at 2:10 PM, Manuel Kaufmann <humi...@gmail.com> wrote: > The only thing that I do not understand well is this comment / > section. Can you explain to me this a bit more? Thanks
What is unclear? The only thing I could add is a pre-amble: Previous code deleted all metadata entries for a given DS entry and then recreated them, on every call to update(). This caused immediate loss of metadata in the case of ENOSPC or any other I/O problem. With this patch: - only delete metadata files for keys that are being removed - only write files when the data changes - write/replace metadata files atomically, to avoid corrupting existing data in case of an error With this patch, we no longer corrupt metadata when trying to edit/update a ds entry with the system hitting ENOSPC. Signed-off-by: Martin Langhoff <mar...@laptop.org> -- now, if you read carefully, it is the same thing I say in the last paragraph :-) m -- mar...@laptop.org -- Software Architect - OLPC - ask interesting questions - don't get distracted with shiny stuff - working code first - http://wiki.laptop.org/go/User:Martinlanghoff _______________________________________________ Sugar-devel mailing list Sugar-devel@lists.sugarlabs.org http://lists.sugarlabs.org/listinfo/sugar-devel