Sun, 31 Jul 2011 22:28:36 +0200, /Jens Hatlak/:
Stanimir Stamenkov wrote:

1. Secure Login <https://addons.mozilla.org/addon/secure-login/>

It is not packaged as SeaMonkey compatible but is easily patched
to make it so - see "secure_login+sm.diff" attached.

That's a good start, but there are some more issues hidden under the
hood. For example, the automatic submitting doesn't seem to work
with SM (i.e. needs further fixes). One issue I've found is in
secureLogin.js, function initializeSignonAutofillFormsStatus.
There's a version check that doesn't take the application into
account. The author's intention was to check for FF 2.x, but SM 2.x
also runs into that code.

It would be great if you could get this extension running with SM
completely and then contact the author. If he doesn't want to
incorporate the changes into his version, I'm sure Philip Chee would
be glad to put your mod on his site (license it GPL, so should be OK).

[I thought I've posted this yesterday, but seems I've missed.]

I've already contacted the author (Sebastian Tschan) and he replied I should now contact the Abine company, being current maintainer of the extension. I've mailed them, also. In the meantime one may find updated compatibility patch attached to this message.

--
Stanimir
diff -r 24cdf01c656f chrome.manifest
--- a/chrome.manifest   Sun Jul 31 19:05:46 2011 +0300
+++ b/chrome.manifest   Tue Aug 02 00:54:04 2011 +0300
@@ -19,6 +19,7 @@
 locale         securelogin     zh-TW                   chrome/locale/zh-TW/
 skin           securelogin     classic/1.0             chrome/skin/
 overlay                chrome://browser/content/browser.xul                    
                chrome://securelogin/content/secureLoginOverlay.xul
+overlay                chrome://navigator/content/navigator.xul                
                chrome://securelogin/content/secureLoginOverlay.xul
 style          chrome://global/content/customizeToolbar.xul                    
chrome://securelogin/skin/secureLogin.css
 style          chrome://browser/content/browser.xul                            
        chrome://securelogin/skin/secureLogin1.5.css                    
appversion<2.0
 style          chrome://securelogin/content/secureLoginOptions.xul             
chrome://securelogin/skin/secureLoginOptions1.5.css             appversion<2.0
diff -r 24cdf01c656f chrome/content/secureLogin.js
--- a/chrome/content/secureLogin.js     Sun Jul 31 19:05:46 2011 +0300
+++ b/chrome/content/secureLogin.js     Tue Aug 02 00:54:04 2011 +0300
@@ -187,7 +187,7 @@
                // Disable the prefilling of login forms if enabled, remember 
status:
                try {
                        var rootPrefBranch = 
this.getPrefManager().getBranch('');
-                       
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+                       
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion, 
'1.8.*') < 0) {
                                // Firefox version 1.5 - 2.0.0.*:
                                
if(rootPrefBranch.getBoolPref('signon.prefillForms')) {
                                        
rootPrefBranch.setBoolPref('signon.prefillForms', false);
@@ -1994,7 +1994,7 @@
                                url = doc.location.href + 
this.secureLoginPrefs.getCharPref('secureLoginBookmarkHash');
                        }
 
-                       
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+                       
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion, 
'1.8.*') < 0) {
                                // Firefox version 1.5 - 2.0.0.*:
                                var bookmarkArguments = {
                                        name: doc.title,
@@ -2483,7 +2483,7 @@
        finalizeSignonAutofillFormsStatus: function() {
                // Re-enable the prefilling of login forms if setting has been 
true:
                try {
-                       
if(this.getVersionComparator().compare(this.getAppInfo().version, '2.*') < 0) {
+                       
if(this.getVersionComparator().compare(this.getAppInfo().platformVersion, 
'1.8.*') < 0) {
                                // Firefox version 1.5 - 2.0.0.*:
                                if(this.autofillForms) {
                                        
this.getPrefManager().getBranch('').setBoolPref('signon.prefillForms', true);
diff -r 24cdf01c656f install.rdf
--- a/install.rdf       Sun Jul 31 19:05:46 2011 +0300
+++ b/install.rdf       Tue Aug 02 00:54:04 2011 +0300
@@ -17,6 +17,14 @@
                                <em:maxVersion>6.*</em:maxVersion>
                        </Description>
                </em:targetApplication>
+               <em:targetApplication>
+                       <Description>
+                               <!-- SeaMonkey -->
+                               
<em:id>{92650c4d-4b8e-4d2a-b7eb-24ecf4f6b63a}</em:id>
+                               <em:minVersion>2.2</em:minVersion>
+                               <em:maxVersion>2.3.*</em:maxVersion>
+                       </Description>
+               </em:targetApplication>
            <em:translator>Fingli (Bulgarian)</em:translator>
            <em:translator>PetrTwo (Czech)</em:translator>
            <em:translator>Oliver Roth (German)</em:translator>
_______________________________________________
support-seamonkey mailing list
support-seamonkey@lists.mozilla.org
https://lists.mozilla.org/listinfo/support-seamonkey

Reply via email to