[ Not need to cc, I joined the list ] On Tue, 27 Jun 2006 21:22:40 +0200 Luca <[EMAIL PROTECTED]> wrote:
> Il Tue, Jun 27, 2006 at 01:11:23PM +0200, Tim Dijkstra ha scritto: > > Second, suspend is not a good name for a binary. Because (as other > > people have brought up already) suspend is a build in command in > > bash. > > This was rasied a few days ago, it was decided to change name after > 0.2. OK, that's nice, didn't know that. > > > > I attached a patch that does just that. > > Please, put the patch inline for easier review. Will do that next time ;) > > diff -ur suspend-0.2/Makefile trunk/Makefile > > --- suspend-0.2/Makefile 2006-05-01 12:40:21.000000000 +0200 > > +++ trunk/Makefile 2006-06-27 10:39:42.000000000 +0200 > > @@ -35,7 +39,7 @@ > > SPLASHOBJ = splash.o bootsplash.o > > > > clean: > > - rm -f suspend suspend-keygen suspend.keys resume s2ram *.o > > vbetool/*.o vbetool/x86emu/*.o vbetool/x86emu/*.a > > + rm -f $(S2DISK) $(S2BOTH) suspend-keygen suspend.keys > > resume s2ram *.o vbetool/*.o vbetool/x86emu/*.o vbetool/x86emu/*.a > > We build an object called s2disk, s2both is just a symlink done by > 'install', it's not present in the source dir. Right, I made the link during my tests, not anymore. Well spotted... > Coding style: .. > Same here. .. > These minor issues aside I like the idea :) I will use more spaces next time, I promise;) Or do you want me to redo the patch? grts Tim
signature.asc
Description: PGP signature
Using Tomcat but need to do more? Need to support web services, security? Get stuff done quickly with pre-integrated technology to make your job easier Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________ Suspend-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/suspend-devel
