Hi,

i silently fixed this one today:

Index: swsusp.h
===================================================================
RCS file: /cvsroot/suspend/suspend/swsusp.h,v
retrieving revision 1.28
retrieving revision 1.29
diff -u -p -r1.28 -r1.29
--- swsusp.h    26 Sep 2006 12:30:33 -0000      1.28
+++ swsusp.h    12 Oct 2006 12:54:27 -0000      1.29
@@ -106,12 +106,12 @@ static inline int atomic_restore(int dev

 static inline int platform_prepare(int dev)
 {
-       return ioctl(dev, SNAPSHOT_PMOPS, PMOPS_FINISH);
+       return ioctl(dev, SNAPSHOT_PMOPS, PMOPS_PREPARE);
 }

 static inline int platform_enter(int dev)
 {
-       return ioctl(dev, SNAPSHOT_PMOPS, PMOPS_FINISH);
+       return ioctl(dev, SNAPSHOT_PMOPS, PMOPS_ENTER);
 }

 static inline int platform_finish(int dev)

So if the platform mode did nothing good (or bad) for you, you might want
to retest.

...interestingly, only using ->finish all the time was enough to fix
batteries on hp, but unsurprisingly it did not help in making the toughbook
resume without going through BIOS initialization ;-)

This seems to work fine for me now, in fact even better than the in-kernel
suspend, which never calls pm_ops->prepare (will send a fix to lkml for this
later)
-- 
Stefan Seyfried
QA / R&D Team Mobile Devices        |              "Any ideas, John?"
SUSE LINUX Products GmbH, Nürnberg  | "Well, surrounding them's out." 

-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel

Reply via email to