Hi!
On Wednesday 10 January 2007 10:39, Pavel Machek wrote:
> Well, Frank was wrong here for subtle reason, and I did not like it:
>
> If malloc failed (basically can not happen, but...) he'd suspend,
> anyway, failing to restore PCI config at the exit, and bringing video
> corruption back to us... Without knowing that pci save state failed.
You are absolutly right, this wan't that nice. But it still could happen,
that find_vga returns NULL (eventhoug of course this is now very unlikely)
and furthermore we now have a second global variable for
the same thing (global static pointer to global static struct).
So, i did a further cleanup to this patch. This version has only one global
struct for the vga_dev and terminates execution if vga_dev
couldn't be found.
Have fun, :)
Frank
Index: s2ram.c
===================================================================
--- s2ram.c
+++ s2ram.c
@@ -11,12 +11,17 @@
#include <errno.h>
#include <string.h>
+#include <pci/pci.h>
+
#define S2RAM
#include "vbetool/vbetool.h"
#include "vt.h"
#include "s2ram.h"
static void *vbe_buffer;
+unsigned char vga_pci_state[256];
+static struct pci_dev vga_dev;
+static struct pci_access *pacc = NULL;
/* Flags set from whitelist */
static int flags, vbe_mode = -1;
char bios_version[1024], sys_vendor[1024], sys_product[1024],
sys_version[1024];
@@ -36,6 +41,7 @@ char bios_version[1024], sys_vendor[1024
#define UNSURE 0x20 /* unverified entries from acpi-support 0.59 */
#define NOFB 0x40 /* must not use a frame buffer */
#define VBE_MODE 0x80 /* machine needs "vbetool vbemode get / set" */
+#define PCI_SAVE 0x100 /* we need to save the VGA PCI registers */
#include "whitelist.c"
@@ -67,14 +73,15 @@ void machine_known(int i)
" bios_version = '%s'\n", i,
whitelist[i].sys_vendor, whitelist[i].sys_product,
whitelist[i].sys_version, whitelist[i].bios_version);
- printf("Fixes: 0x%x %s%s%s%s%s%s%s\n", flags,
+ printf("Fixes: 0x%x %s%s%s%s%s%s%s%s\n", flags,
(flags & VBE_SAVE) ? "VBE_SAVE " : "",
(flags & VBE_POST) ? "VBE_POST " : "",
(flags & VBE_MODE) ? "VBE_MODE " : "",
(flags & RADEON_OFF) ? "RADEON_OFF " : "",
(flags & S3_BIOS) ? "S3_BIOS " : "",
(flags & S3_MODE) ? "S3_MODE " : "",
- (flags & NOFB) ? "NOFB " : "");
+ (flags & NOFB) ? "NOFB " : "",
+ (flags & PCI_SAVE) ? "PCI_SAVE " : "");
if (flags & UNSURE)
printf("Machine is in the whitelist but perhaps using "
"vbetool unnecessarily.\n"
@@ -143,6 +150,37 @@ int s2ram_check(int id)
return ret;
}
+int find_vga(void)
+{
+ struct pci_dev *dev;
+
+ pci_scan_bus(pacc); /* We want to get the list of devices */
+
+ for (dev=pacc->devices; dev; dev=dev->next) {
+ pci_fill_info(dev, PCI_FILL_IDENT | PCI_FILL_CLASS);
+ if (dev->device_class == 0x300)
+ break;
+ }
+
+ if (!dev)
+ return 1;
+
+ memcpy(&vga_dev, dev, sizeof(*dev));
+ vga_dev.next = NULL;
+
+ return 0;
+}
+
+void save_vga_pci(void)
+{
+ pci_read_block(&vga_dev, 0, vga_pci_state, 256);
+}
+
+void restore_vga_pci(void)
+{
+ pci_write_block(&vga_dev, 0, vga_pci_state, 256);
+}
+
/* warning: we have to be on a text console when calling this */
int s2ram_hacks(void)
{
@@ -171,6 +209,17 @@ int s2ram_hacks(void)
printf("Calling radeon_cmd_light(0)\n");
radeon_cmd_light(0);
}
+ if (flags & PCI_SAVE) {
+ pacc = pci_alloc(); /* Get the pci_access structure */
+ pci_init(pacc); /* Initialize the PCI library */
+
+ if (find_vga() == 0) {
+ printf("saving PCI config of device %02x:%02x.%d\n",
+ vga_dev.bus, vga_dev.dev, vga_dev.func);
+ save_vga_pci();
+ } else
+ return 1;
+ }
return 0;
}
@@ -216,6 +265,13 @@ int s2ram_do(void)
void s2ram_resume(void)
{
+ if ((flags & PCI_SAVE) && vga_dev.device_class == 0x300) {
+ printf("restoring PCI config of device %02x:%02x.%d\n",
+ vga_dev.bus, vga_dev.dev, vga_dev.func);
+ restore_vga_pci();
+
+ pci_cleanup(pacc);
+ }
// FIXME: can we call vbetool_init() multiple times without cleaning up?
if (flags & VBE_POST) {
vbetool_init();
@@ -260,6 +316,7 @@ static void usage(void)
" -a, --acpi_sleep: set the acpi_sleep parameter before "
"suspend\n"
" 1=s3_bios, 2=s3_mode, 3=both\n"
+ " -v, --pci_save: save the PCI config space for the VGA
card.\n"
"\n");
exit(1);
}
@@ -278,10 +335,11 @@ int main(int argc, char *argv[])
{ "radeontool", no_argument, NULL, 'r'},
{ "identify", no_argument, NULL, 'i'},
{ "acpi_sleep", required_argument, NULL, 'a'},
+ { "pci_save", no_argument, NULL, 'v'},
{ NULL, 0, NULL, 0 }
};
- while ((i = getopt_long(argc, argv, "nhfspmria:", options, NULL)) !=
-1) {
+ while ((i = getopt_long(argc, argv, "nhfspmriva:", options, NULL)) !=
-1) {
switch (i) {
case 'h':
usage();
@@ -311,6 +369,9 @@ int main(int argc, char *argv[])
case 'a':
flags |= (atoi(optarg) & (S3_BIOS | S3_MODE));
break;
+ case 'v':
+ flags |= PCI_SAVE;
+ break;
default:
usage();
break;
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
Suspend-devel mailing list
Suspend-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/suspend-devel
