On Wed 2007-01-10 13:09:57, Stefan Seyfried wrote: > On Wed, Jan 10, 2007 at 12:26:07PM +0100, Pavel Machek wrote: > > Hi! > > > > > > Well, Frank was wrong here for subtle reason, and I did not like it: > > > > > > > > If malloc failed (basically can not happen, but...) he'd suspend, > > > > anyway, failing to restore PCI config at the exit, and bringing video > > > > corruption back to us... Without knowing that pci save state failed. > > > You are absolutly right, this wan't that nice. But it still could happen, > > > that find_vga returns NULL (eventhoug of course this is now very unlikely) > > > and furthermore we now have a second global variable for > > > the same thing (global static pointer to global static struct). > > > > > > So, i did a further cleanup to this patch. This version has only one > > > global > > > struct for the vga_dev and terminates execution if vga_dev > > > couldn't be found. > > > > If you can get me version relative to current cvs, > > here it is (some small changes to Frank's patch are: do not initialize *pacc, > static vga_pci_state, a comment on why we fail suspend, whitespace > cleanups):
ACK, please commit. -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
