Hi, On Tuesday, 27 March 2007 15:18, Tim Dijkstra wrote: > Hi, > > I think we agree that it would be nice for s2both to have the same > commandline options as s2ram. Well, here is a patch;) A few comments: > > The logic I choose for s2both is to continue with suspend-to-disk > in case of an error in the s2ram part. Even if the problem is with cli > options. This is how it was until know... > > To minimize duplication, I moved some things around in s2ram. Only > the option string is duplicated now. We could of course do a > s2ram_get_optstring function... > > I changed the short option for s2both/s2disk --config, > which currently is -f to -c, so we can use -f for --force. This of > course breaks stefan his scripts;)
Generally looks good, but this last change breaks many existing setups (which is why I haven't added the s2ram options to s2both myself yet ;-)). I think we can use another option for 'force' in s2both, like '-w' (for 'no whitelist'). Greetings, Rafael ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ Suspend-devel mailing list Suspend-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/suspend-devel
