On 25 January 2018 at 21:02, Matt Joras <matt.jo...@gmail.com> wrote: > On Thu, Jan 25, 2018 at 8:52 PM, Warner Losh <i...@bsdimp.com> wrote: >> >> >> On Thu, Jan 25, 2018 at 9:40 PM, Eitan Adler <ead...@freebsd.org> wrote: >>> >>> Author: eadler >>> Date: Fri Jan 26 04:40:41 2018 >>> New Revision: 328430 >>> URL: https://svnweb.freebsd.org/changeset/base/328430 >>> >>> Log: >>> devd: minor nits >>> >>> - mark usage as noreturn >>> - config does not need a virtual destructor >> >> >> Everything needs a virtual destructor... Please back that part of this >> out... >> >> Warner > Needs? If there's not inheritance there's no _need_ to do it, and it's > arguably superfluous. That being said it's also an arguably > superfluous change to remove it.
Yeah, I don't think this needs it. That said, readded in 328431. I removed it originally since it was the only virtual function in config and it seemed out of place. At the least, I went looking for what inherited from it. -- Eitan Adler Source, Ports, Doc committer Bugmeister, Ports Security teams _______________________________________________ svn-src-head@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/svn-src-head To unsubscribe, send any mail to "svn-src-head-unsubscr...@freebsd.org"
