- Dennis > On May 12, 2016, at 9:34 AM, Pierre Habouzit <phabou...@apple.com> wrote: > >> On May 11, 2016, at 9:02 AM, Dennis Weissmann via swift-evolution >> <swift-evolution@swift.org <mailto:swift-evolution@swift.org>> wrote: >> >> 1. What is your evaluation of the proposal? >> +1 I think this is a big win for readability. >> >> 2. Is the problem being addressed significant enough to warrant a change to >> Swift? >> Yes. dispatch is used nearly everywhere so many many projects would benefit >> from it. >> >> 3. Does this proposal fit well with the feel and direction of Swift? >> Making the API more “swift" and feel more natural definitely is the >> direction Swift libraries are / should be going in. >> >> 4. If you have used other languages or libraries with a similar feature, how >> do you feel that this proposal compares to those? >> Unfortunately not. >> >> 5. How much effort did you put into your review? A glance, a quick reading, >> or an in-depth study? >> Read the proposal twice. >> >> A little nitpick: >> >> let item = DispatchWorkItem(qos: .qosUserInitiated) { >> print("Hello World") >> } >> >> I’d change the enum case from .qosUserInitiated to .userInitiated (maybe >> that’s just a typo since in the code example before uses .unspecified). > > I think it is a typo, only default needs to be qosDefault because default is > a keyword, and asking all users to back-tick it isn’t really good either. > (also no one should really specify qos class default anyway).
Even .default should be okay once SE-0071 <https://github.com/apple/swift-evolution/blob/23da9e94fd9580e59bdae50abf122d3d3c852a8f/proposals/0071-member-keywords.md> is implemented. >> >> - Dennis >> >>> On May 11, 2016, at 6:39 AM, Chris Lattner <clatt...@apple.com >>> <mailto:clatt...@apple.com>> wrote: >>> >>> Hello Swift community, >>> >>> The review of "SE-0088: Modernize libdispatch for Swift 3 naming >>> conventions" begins now and runs through May 17. The proposal is available >>> here: >>> >>> >>> https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md >>> >>> <https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md> >>> >>> Reviews are an important part of the Swift evolution process. All reviews >>> should be sent to the swift-evolution mailing list at >>> >>> https://lists.swift.org/mailman/listinfo/swift-evolution >>> <https://lists.swift.org/mailman/listinfo/swift-evolution> >>> >>> or, if you would like to keep your feedback private, directly to the review >>> manager. >>> >>> What goes into a review? >>> >>> The goal of the review process is to improve the proposal under review >>> through constructive criticism and contribute to the direction of Swift. >>> When writing your review, here are some questions you might want to answer >>> in your review: >>> >>> * What is your evaluation of the proposal? >>> * Is the problem being addressed significant enough to warrant a change >>> to Swift? >>> * Does this proposal fit well with the feel and direction of Swift? >>> * If you have used other languages or libraries with a similar feature, >>> how do you feel that this proposal compares to those? >>> * How much effort did you put into your review? A glance, a quick >>> reading, or an in-depth study? >>> >>> More information about the Swift evolution process is available at >>> >>> https://github.com/apple/swift-evolution/blob/master/process.md >>> >>> Thank you, >>> >>> -Chris Lattner >>> Review Manager >>> >>> >>> >>> _______________________________________________ >>> swift-evolution-announce mailing list >>> swift-evolution-annou...@swift.org >>> https://lists.swift.org/mailman/listinfo/swift-evolution-announce >> >> _______________________________________________ >> swift-evolution mailing list >> swift-evolution@swift.org <mailto:swift-evolution@swift.org> >> https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
