Great, this is the libdispatch API that I’ve been dreaming about! I think it meshes well with the rest of Swift.
I am concerned about one thing though: the naming of the DispatchGroup methods synchronously/asynchronously. They are hard to type correctly and ugly to look at. sync/async are already well-established abbreviations in the tech industry. They are adjectives without verbs, which goes against the API Design Guidelines. I suggest sticking with the naming from the C API. For example: let queue = … queue.dispatchAsync { … } Cheers, Darren > Hello Swift community, > > The review of "SE-0088: Modernize libdispatch for Swift 3 naming conventions" > begins now and runs through May 17. The proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0088-libdispatch-for-swift3.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the review > manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. When > writing your review, here are some questions you might want to answer in your > review: > > * What is your evaluation of the proposal? > * Is the problem being addressed significant enough to warrant a change to > Swift? > * Does this proposal fit well with the feel and direction of Swift? > * If you have used other languages or libraries with a similar feature, how > do you feel that this proposal compares to those? > * How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > -Chris Lattner > Review Manager > > >
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution