Re: [swift-evolution] [Review] SE-0113: Add integral rounding functions to FloatingPoint

[David Rönnqvist via swift-evolution]

Sent from my iPad
> On 1 Jul 2016, at 08:02, Chris Lattner via swift-evolution 
> <swift-evolution@swift.org> wrote:
> 
> Hello Swift community,
> 
> The review of "SE-0113: Add integral rounding functions to FloatingPoint" 
> begins now and runs through July 5. The proposal is available here:
> 
>    
> https://github.com/apple/swift-evolution/blob/master/proposals/0113-rounding-functions-on-floatingpoint.md
> 
> Reviews are an important part of the Swift evolution process. All reviews 
> should be sent to the swift-evolution mailing list at
> 
>    https://lists.swift.org/mailman/listinfo/swift-evolution
> 
> or, if you would like to keep your feedback private, directly to the review 
> manager.
> 
> What goes into a review?
> 
> The goal of the review process is to improve the proposal under review 
> through constructive criticism and contribute to the direction of Swift. When 
> writing your review, here are some questions you might want to answer in your 
> review:
> 
>    * What is your evaluation of the proposal?

+1. Small, simple, and "Swifty"

Regarding the proposal itself (as opposed to the proposed solution):
Rounding to a specific precision (e.g. 2 decimals) was discussed prior to the 
proposal and could be mentioned under Alternatives Considered with an 
explanation of why it was excluded form the proposal.

>    * Is the problem being addressed significant enough to warrant a change to 
> Swift?

Yes, probably. It's a small change for a small problem

>    * Does this proposal fit well with the feel and direction of Swift?

Yes. The proposed solution feels more at home in Swift than what's currently 
there and fits the general direction of preferring member functions over free 
functions.

>    * If you have used other languages or libraries with a similar feature, 
> how do you feel that this proposal compares to those?

I've used the floor and ceil functions in various C based languages. Those fit 
in with the style of C, and these fit in with the style and naming conventions 
of Swift.

I've also used Math.Round in Visual Basic a long time ago (don't judge me). It 
allows for two rounding modes (AwayFromZero and ToEven (bankers rounding)). I 
had to look that up because I didn't remember how it actually worked.

In each case (including this proposal) I feel that the various solutions feel 
right at home in their various contexts.

>    * How much effort did you put into your review? A glance, a quick reading, 
> or an in-depth study?

Read the proposal. Skimmed the discussion.

> 
> More information about the Swift evolution process is available at
> 
>    https://github.com/apple/swift-evolution/blob/master/process.md
> 
> Thank you,
> 
> -Chris Lattner
> Review Manager
> 
> _______________________________________________
> swift-evolution mailing list
> swift-evolution@swift.org
> https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution