+1. These additions are appreciated and well thought out.
> On Jun 30, 2016, at 11:02 PM, Chris Lattner <clatt...@apple.com> wrote: > > Hello Swift community, > > The review of "SE-0113: Add integral rounding functions to FloatingPoint" > begins now and runs through July 5. The proposal is available here: > > > https://github.com/apple/swift-evolution/blob/master/proposals/0113-rounding-functions-on-floatingpoint.md > > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at > > https://lists.swift.org/mailman/listinfo/swift-evolution > > or, if you would like to keep your feedback private, directly to the review > manager. > > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and contribute to the direction of Swift. When > writing your review, here are some questions you might want to answer in your > review: > > * What is your evaluation of the proposal? +1 > * Is the problem being addressed significant enough to warrant a change > to Swift? yes. They ease the burden on usage of swift. > * Does this proposal fit well with the feel and direction of Swift? y > * If you have used other languages or libraries with a similar feature, > how do you feel that this proposal compares to those? They depart from the well-known and common floor() and ceil(), which may be confusing to some users. On balance, however, I believe these approach taken is cleaner and should be adopted. > * How much effort did you put into your review? A glance, a quick > reading, or an in-depth study? I followed the mailing list discussion and carefully read the proposal a number of times. James > > More information about the Swift evolution process is available at > > https://github.com/apple/swift-evolution/blob/master/process.md > > Thank you, > > -Chris Lattner > Review Manager > > _______________________________________________ > swift-evolution-announce mailing list > swift-evolution-annou...@swift.org > https://lists.swift.org/mailman/listinfo/swift-evolution-announce _______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
