Hi Itai,
I’m wondering what the motivation is for keeping this as part of Foundation and
not the standard library. It seems like you’re landing an implementation of
this in the Foundation overlay on master, and another copy of all the code will
have to go into swift-corelibs-foundation. This seems suboptimal. Or are there
future plans to unify the Foundation overlay with corelibs-foundation somehow?
Also the implementation uses some Foundation-isms (NSMutableArray, NSNumber)
and it would be nice to stick with idiomatic Swift as much as possible instead.
Finally you should take a look at the integer protocol work
(https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md
<https://github.com/apple/swift-evolution/blob/master/proposals/0104-improved-integers.md>)
to replace the repetitive code surrounding primitive types, however I don’t
know if this has landed in master yet.
Slava
_______________________________________________
swift-evolution mailing list
swift-evolution@swift.org
https://lists.swift.org/mailman/listinfo/swift-evolution
