> On May 11, 2017, at 6:08 PM, Nevin Brackett-Rozinsky via swift-evolution > <swift-evolution@swift.org> wrote: > > Looks good at first glance. > > Is there a diff showing what’s changed though?
This seems to work: https://github.com/apple/swift-evolution/compare/4cbb1f1fa836496d4bfba95c4b78a9754690956d...master#diff-e04958ae62d5b65cb356dfe928b24837 (Ignore the changes to other files.) John. > > Nevin > > On Thu, May 11, 2017 at 5:39 PM, John McCall via swift-evolution > <swift-evolution@swift.org <mailto:swift-evolution@swift.org>> wrote: > Hello Swift Community, > > The review of SE-0163: "String Revision: Collection Conformance, C Interop, > Transcoding" begins now and runs through May 15th, 2017. > > The first version of this proposal was accepted with revisions. The proposed > revisions were just a few additions that were publicly requested and agreed > to during the first review, and this would not normally require a full second > review. However, as we worked to implement the proposal, several minor naming > changes suggested themselves that had not been previously discussed. The Core > Team felt that the most conscientious approach would be to submit the whole > proposal for a short re-review. > > The most noticeable change is that the Core Team feels StringProtocol would > be a better name for the protocol unifying String and Substring. Unicode was > felt to be slightly intimidating. Not using Unicode as the protocol name also > has the benefit of allowing it to be used as a namespace to house > Unicode-related types. > The proposal is available here: > > https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md> > Reviews are an important part of the Swift evolution process. All reviews > should be sent to the swift-evolution mailing list at: > > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > or, if you would like to keep your feedback private, directly to the review > manager. > > When replying, please try to keep the proposal link at the top of the message: > > Proposal link: > > https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md > > <https://github.com/apple/swift-evolution/blob/master/proposals/0163-string-revision-1.md> > Reply text > > Other replies > > <https://github.com/apple/swift-evolution#what-goes-into-a-review-1> > What goes into a review? > > The goal of the review process is to improve the proposal under review > through constructive criticism and, eventually, determine the direction of > Swift. When writing your review, here are some questions you might want to > answer in your review: > > What is your evaluation of the proposal? > Is the problem being addressed significant enough to warrant a change to > Swift? > Does this proposal fit well with the feel and direction of Swift? > If you have used other languages or libraries with a similar feature, how do > you feel that this proposal compares to those? > How much effort did you put into your review? A glance, a quick reading, or > an in-depth study? > More information about the Swift evolution process is available at: > > https://github.com/apple/swift-evolution/blob/master/process.md > <https://github.com/apple/swift-evolution/blob/master/process.md> > > Thanks, > John McCall > Review Manager > > _______________________________________________ > swift-evolution mailing list > swift-evolution@swift.org <mailto:swift-evolution@swift.org> > https://lists.swift.org/mailman/listinfo/swift-evolution > <https://lists.swift.org/mailman/listinfo/swift-evolution> > > > _______________________________________________ > swift-evolution mailing list > swift-evolution@swift.org > https://lists.swift.org/mailman/listinfo/swift-evolution
_______________________________________________ swift-evolution mailing list swift-evolution@swift.org https://lists.swift.org/mailman/listinfo/swift-evolution
