On 5/15/2015 5:49 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8078514
webrev: http://cr.openjdk.java.net/~ssadetsky/8078514/webrev.00/
DefaultRowSorter
221 allChanged();
222 modelRowCount = getModelWrapper().getRowCount();
- This can be moved to a private method that will be used both in the
public modelStructureChanged() and setModelWrapper() methods.
532 public void sort()
- Could the rawFilter be null in case viewToModel != null an !isUnsorted() ?
- isUnsorted() method is called twice. Is it possible to store its value
to a variable and use it?
Thanks,
Alexandr.
The 6894632 fix violated a contract between the table and its row
sorter: the sorter should receive TableChanged events even if table is
not sorted actually.
Another way to fix 6894632 is to initialize sorter internal structures
instantly. The last is applied in the fix.
--Semyon
