Hello Ajit,

Fix looks fine to me. Few comments about test case.
1) @run main is missing in test.
2) JFrame dispose should be done in swing thread.

Regards,
Rajeev Chamyal


-----Original Message-----
From: Ajit Ghaisas 
Sent: 06 May 2016 12:52
To: Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: <Swing Dev> [9] Fix for JDK-7172750 : Nimbus 
ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked

Hi,

Bug : 
     https://bugs.openjdk.java.net/browse/JDK-7172750

Issue :
    Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked
    
Root Cause :
    There is no differentiation between 'MouseOver' and Mouse 'Pressed' in 
scroll thumb painting.

Fix :
     1. Used existing member boolean 'dragging' from BasicScrollBarUI class in 
SynthScrollBarUI class to differentiate between "mouse over" and "mouse 
pressed" state.
     2. Added a test case - it passes on Windows, Linux and Mac.

Please review the webrev : 
    http://cr.openjdk.java.net/~aghaisas/7172750/webrev.00/

Regards,
Ajit

Reply via email to