Thanks for the review. I have corrected the test case to dispose the window if the test fails.
Here is the updated webrev. http://cr.openjdk.java.net/~aghaisas/7172750/webrev.02/ Regards, Ajit -----Original Message----- From: Sergey Bylokhov Sent: Wednesday, May 18, 2016 10:30 PM To: Ajit Ghaisas; Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> [9] Fix for JDK-7172750 : Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked Hi, Ajit. The fix looks fine. one note about the test, please dispose the window if the test fails. Currently disposeTestUI() will be skipped in case of any exceptions. On 17.05.16 13:19, Ajit Ghaisas wrote: > Thanks for the review. > > I have updated the test case to include suggested corrections. > Please review : > http://cr.openjdk.java.net/~aghaisas/7172750/webrev.01/ > > Regards, > Ajit > > -----Original Message----- > From: Rajeev Chamyal > Sent: Tuesday, May 17, 2016 2:27 PM > To: Ajit Ghaisas; Alexander Scherbatiy; Sergey Bylokhov; > swing-dev@openjdk.java.net > Subject: RE: <Swing Dev> [9] Fix for JDK-7172750 : Nimbus > ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked > > Hello Ajit, > > Fix looks fine to me. Few comments about test case. > 1) @run main is missing in test. > 2) JFrame dispose should be done in swing thread. > > Regards, > Rajeev Chamyal > > > -----Original Message----- > From: Ajit Ghaisas > Sent: 06 May 2016 12:52 > To: Alexander Scherbatiy; Sergey Bylokhov; swing-dev@openjdk.java.net > Subject: <Swing Dev> [9] Fix for JDK-7172750 : Nimbus > ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is never invoked > > Hi, > > Bug : > https://bugs.openjdk.java.net/browse/JDK-7172750 > > Issue : > Nimbus ScrollBar:ScrollBarThumb[Pressed].backgroundPainter is > never invoked > > Root Cause : > There is no differentiation between 'MouseOver' and Mouse 'Pressed' in > scroll thumb painting. > > Fix : > 1. Used existing member boolean 'dragging' from BasicScrollBarUI class > in SynthScrollBarUI class to differentiate between "mouse over" and "mouse > pressed" state. > 2. Added a test case - it passes on Windows, Linux and Mac. > > Please review the webrev : > http://cr.openjdk.java.net/~aghaisas/7172750/webrev.00/ > > Regards, > Ajit > -- Best regards, Sergey.
