Hello Yuri, Thanks for +1. I have changed the Color to green.
Regards, Rajeev Chamyal -----Original Message----- From: Yuri Nesterenko Sent: 19 August 2016 17:38 To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net Subject: Re: <Swing Dev> Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] Some issues in java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java Indeed. I tried it myself, and it is yellow for me, too... but, on a snapshot and with my nose to the screen:-) I approve the test as it is but some other color perhaps could be more visible. I know the RED is taken but maybe green or orange? Anyway, +1. -yan On 08/19/2016 02:37 PM, Rajeev Chamyal wrote: > Hello Yuri, > > I have attached a snapshot of button in JBS. The button icon border is Yellow. > https://bugs.openjdk.java.net/browse/JDK-8163160 > > Regards, > Rajeev Chamyal > > -----Original Message----- > From: Yuri Nesterenko > Sent: 19 August 2016 16:38 > To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy; > swing-dev@openjdk.java.net > Subject: Re: <Swing Dev> Swing Dev>[9] Review Request JDK-8163160 > [PIT][TEST_BUG] Some issues in > java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java > > Hi Rajeev, > > I tried this version of the test on two Ubuntu 16.04 systems with Unity and a > promoted b132. > Now, the Launcher icon is blue with yellow border around it -- but the icon > on the frame with label "Test" is blue with gray border. I think you should > either change instructions even more or look into that issue (if there's an > issue). > > Thank you, > -yan > > On 08/19/2016 08:06 AM, Rajeev Chamyal wrote: >> Hello Yuri, >> >> Can you please review below webrev. >> Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ >> >> Regards, >> Rajeev Chamyal >> >> -----Original Message----- >> From: Rajeev Chamyal >> Sent: 16 August 2016 18:45 >> To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net >> Subject: Re: <Swing Dev> Swing Dev>[9] Review Request JDK-8163160 >> [PIT][TEST_BUG] Some issues in >> java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java >> >> Hello Sergey, >> >> Thanks for the review. In the bug its reported that border of button is grey. >> Instead of button border icon border should be checked. I have updated test >> instructions for this. >> >> Regards, >> Rajeev Chamyal >> >> -----Original Message----- >> From: Sergey Bylokhov >> Sent: 16 August 2016 18:28 >> To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net >> Subject: Re: Swing Dev>[9] Review Request JDK-8163160 [PIT][TEST_BUG] >> Some issues in >> java/awt/image/multiresolution/MultiResolutionIcon/IconTest.java >> >> On 16.08.16 15:57, Sergey Bylokhov wrote: >>> The changes looks fine, there are a notice, is it a known issues? >> >> there are a notice about different background of the buttons. >> >>> >>> On 16.08.16 15:01, Rajeev Chamyal wrote: >>>> Hello All, >>>> >>>> >>>> >>>> Please review the following webrev. >>>> >>>> >>>> >>>> Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/ >>>> >>>> Bug : https://bugs.openjdk.java.net/browse/JDK-8163160 >>>> >>>> Issue : manual tag was missing in test. >>>> >>>> >>>> >>>> Regards, >>>> >>>> Rajeev Chamyal >>>> >>>> >>>> >>> >>> >> >> >
