I object (luke-warmly). Cross-references are (in the ESV) tied to the word in front. If you put a space in, you can't tell which word (before or after) it is tied to.
Surely this can be fixed in Xiphos? :D God Bless, Ben ------------------------------------------------------------------------------------------- Multitudes, multitudes, in the valley of decision! For the day of the LORD is near in the valley of decision. Giôên 3:14 (ESV) On 14/04/2009, Matthew Talbert <ransom1...@gmail.com> wrote: > > Does anyone have an objection to the following patch? It simply adds a > space between *x or *n and the following word. The lack of a space > causes problems with Xiphos "click to look up a word". The only module > that I know that it affects is the ESV as the majority of the modules > put the crossrefs and footnotes at the end of the words. It is only a > single normal space (as opposed to ) so it should have no effect > if there happen to be two spaces. The RTF filter already does this. > > To be technically correct, I suppose the other filters should have the > same change, although I've never seen a module that put the crossrefs > immediately in front of the word except ESV. > > Matthew > > Index: osishtmlhref.cpp > =================================================================== > --- osishtmlhref.cpp (revision 2322) > +++ osishtmlhref.cpp (working copy) > @@ -246,7 +246,7 @@ > SWCATCH ( ... ) { } > if (vkey) { > //printf("URL = > %s\n",URL::encode(vkey->getText()).c_str()); > - > buf.appendFormatted("<a > > href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a>", > + > buf.appendFormatted("<a > > href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a> > ", > ch, > > URL::encode(footnoteNumber.c_str()).c_str(), > > URL::encode(u->version.c_str()).c_str(), > @@ -254,7 +254,7 @@ > ch); > } > else { > - > buf.appendFormatted("<a > > href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a>", > + > buf.appendFormatted("<a > > href=\"passagestudy.jsp?action=showNote&type=%c&value=%s&module=%s&passage=%s\"><small><sup>*%c</sup></small></a> > ", > ch, > > URL::encode(footnoteNumber.c_str()).c_str(), > > URL::encode(u->version.c_str()).c_str(), > @@ -268,7 +268,7 @@ > if (tag.isEndTag()) { > u->suspendTextPassThru = > (--u->suspendLevel); > u->inXRefNote = false; > - u->lastSuspendSegment = ""; // > fix/work-around for nasb > devineName in note bug > + u->lastSuspendSegment = ""; // > fix/work-around for nasb > divineName in note bug > } > } > > _______________________________________________ > sword-devel mailing list: sword-devel@crosswire.org > http://www.crosswire.org/mailman/listinfo/sword-devel > Instructions to unsubscribe/change your settings at above page >
_______________________________________________ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listinfo/sword-devel Instructions to unsubscribe/change your settings at above page