OK, thanks for the feedback, DM.
OSISHeadings had trouble processing mulitple <title> elements in a
single chunk. I've added support for this now and it seems to have a
much better result. Can people please try it out and let me know how
things work for you? Thanks!
Troy
On 09/30/2012 09:00 PM, DM Smith wrote:
The sID="gen22" is the 22-nd "gen"erated id by osis2mod. There should be a corresponding
eID="gen22" elsewhere in the file.
The odd thing I see is the rendering of the title and the references.
Everything is doubled up.
Some other things to explore when the given example is handled:
A Study Bible can reasonably be expected to have descriptive text between
verses. It may or may not be put in a container (e.g. div, p). It certainly is
not a title.
Typically paragraphing is between verses. There are a common cases where a
paragraph will split verses.
Line groups (aka <lg>) are a special form of a paragraph. And are like
paragraphs, typically surrounding verses and sometimes splitting them.
Footnotes can occur between verses.
So:
<div type="section">
<p> paragraph explaining<note>just a footnote</note> the section</p>
<title>blah blah blah<title>
<p>
<verse>...</verse>
</p>
Another test would be just paragraphing and sectioning without titles or text.
Rendering should be the same regardless if headings is on or off.
<div type="section">
<p>
<verse sID/>...<verse eID/>
<verse eID/> ... </p><p> ... <verse eID>
</p>
On Sep 30, 2012, at 1:43 PM, "Troy A. Griffitts" <scr...@crosswire.org> wrote:
OK, The simple inter-verse material case I was looking to test first was not
present in our osisReference.xml sample in the testsuite.
This case is where we have a interverse material between two consecutive verse
within a chapter (not just before verse 1, because pre-verse-1 is complicated
by the fact that we store chapter/book/testament/module intro material in a
different place than interverse material).
We had a good chunk of interverse material at Mark 1:14 in the
osisReference.xml snippet, but Mark material started at verse 14. So, I've
added a simple Mark 1.13 so the interverse material is simply between verse 13
and verse 14.
I've updated the osistest.cpp file to output information for verse 14.
It seems really strange.
I'll look at it more closely, but it seems something odd is happening in osis2mod. The
preverse material before Mark 1:14 is getting a sID="gen22". Not sure that
affects our filters much, as long as the start and end are consistent. Anyway, can
people have a look and see if you can spot anything odd, and also let me know if this is
an valid, and exemplary interverse snippet for us to use as our use case to work toward
supporting?
see:
sword/tests/testsuite/osisReference.xml
sword/tests/osistest.cpp
and to try,
cd sword/tests/testsuite
./runtest.sh osis
cd osis
../../osistest OSISReference
Thanks for any help in getting this going,
Troy
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page
