Guys, has anyone actually written a test for this ticket API-180?

I have just added one in the latest trunk commit and it seems to work
fine for me.  I used a note similar to the example David has in the
ticket and the output and entryAttributes both look correct.

---------------

... 
  <chapter sID="Ps.3" osisID="Ps.3"/>
    <title type="chapter">PSALM 3.</title>
    <div type="section">
    <title type="psalm" canonical="true">A Psalm of David<note n="A" 
osisID="Ps.3.xref.A" type="crossReference"><reference osisRef="Matt.1.4">Matt 
1:4</reference></note>, when he fled from Absalom his son.</title>
     <p>
      <lg>
       <verse sID="Ps.3.1" osisID="Ps.3.1"/>
...

-----------------

 Rendered Header:

  <h3 class="title psalm canonical">A Psalm of David<a class="noteMarker 
crossReference" 
href="passagestudy.jsp?action=showNote&type=x&value=1&module=OSISReference&passage=Psalms+3%3A1"><small><sup
 class="x">*x</sup></small></a>, when he fled from Absalom his son.</h3>
 
 <br />

------------------

Entry Attributes:

[ Footnote ]
        [ 1 ]
                body = <reference osisRef="Matt.1.4">Matt 1:4</reference>
                n = A
                osisID = Ps.3.xref.A
                refList = Matt.1.4
                type = crossReference
[ Heading ]
        [ 0 ]
                canonical = true
                sID = pv3
                subType = x-preverse
                type = x-milestone
        [ Preverse ]
                0 = <div sID="gen12" type="section"/> <title canonical="true" 
type="psalm">A Psalm of David<note n="A" osisID="Ps.3.xref.A" swordFootnote="1" 
type="crossReference"></note>, when he fled from Absalom his son.</title> <div 
sID="gen13" type="x-p"/> <lg sID="gen14"/> 
                module->renderText(heading[0]) =  <h3 class="title psalm 
canonical">A Psalm of David<a class="noteMarker crossReference" 
href="passagestudy.jsp?action=showNote&type=x&value=1&module=OSISReference&passage=Psalms+3%3A1"><small><sup
 class="x">*x</sup></small></a>, when he fled from Absalom his son.</h3>

<br />




On 1/31/20 4:11 PM, ref...@gmx.net wrote:
> I looked at that a lot of times and decided it is beyond my Ken.
> Sorry. But the list stuff I think I can fix
>
> Sent from my mobile. Please forgive shortness, typos and weird
> autocorrects.
>
>
> -------- Original Message --------
> Subject: Re: [sword-devel] Tei dic in sword
> From: Cyrille
> To: SWORD Developers' Collaboration Forum ,ref...@gmx.net
> CC:
>
>
>     The bug report is here
>     <https://tracker.crosswire.org/projects/API/issues/API-221>. If
>     you have some time to work on the sword issues, please have a look
>     on a more annoying issue: API-180
>     <https://tracker.crosswire.org/projects/API/issues/API-180>
>     Almost 3 bible modules are affected by this issue. Thank you.
>
>     Le 31/01/2020 à 13:34, ref...@gmx.net a écrit :
>>     Put a bug report in please with expected html. I will deal with
>>     it within the next couple of weeks,.
>>
>>     Peter
>>
>>     Sent from my mobile. Please forgive shortness, typos and weird
>>     autocorrects.
>>
>>
>>     -------- Original Message --------
>>     Subject: Re: [sword-devel] Tei dic in sword
>>     From: Greg Hellings
>>     To: SWORD Developers' Collaboration Forum
>>     CC:
>>
>>
>>
>>
>>         On Fri, Jan 31, 2020 at 9:51 AM Cyrille
>>         <lafricai...@gmail.com <mailto:lafricai...@gmail.com>> wrote:
>>
>>
>>
>>             Le 31/01/2020 à 10:48, Karl Kleinpaste a écrit :
>>>             On 1/31/20 10:29 AM, Cyrille wrote:
>>>>             OK, then is it a problem with sword or with Xiphos?
>>>             It's incomplete support in Sword.
>>>
>>>             If you look at Sword's src/modules/filters/teixhtml.cpp,
>>>             the word "list" does not appear. In fact, you can run
>>>             "grep tag.getName teixhtml.cpp" to get a list of the TEI
>>>             keywords that are supported for XHTML rendering.
>>             Would this deserve a bug report? Even if I don't think
>>             there are many people trying to solve the sword bugs...
>>
>>
>>         Yes, also a reasonable patch would add minimal code and you'd get
>>         <list> -> <ul>
>>         <item> -> <li>
>>
>>         And you're probably done everything you need. A bug report
>>         with path is much more readily accepted into Sword than just
>>         a bug report.
>>
>>         --Greg
>>
>>
>>>
>>>             _______________________________________________
>>>             sword-devel mailing list: sword-devel@crosswire.org 
>>> <mailto:sword-devel@crosswire.org>
>>>             http://www.crosswire.org/mailman/listinfo/sword-devel
>>>             Instructions to unsubscribe/change your settings at above page
>>
>>             _______________________________________________
>>             sword-devel mailing list: sword-devel@crosswire.org
>>             <mailto:sword-devel@crosswire.org>
>>             http://www.crosswire.org/mailman/listinfo/sword-devel
>>             Instructions to unsubscribe/change your settings at above
>>             page
>>
>>
>>     _______________________________________________
>>     sword-devel mailing list: sword-devel@crosswire.org
>>     http://www.crosswire.org/mailman/listinfo/sword-devel
>>     Instructions to unsubscribe/change your settings at above page
>
>
> _______________________________________________
> sword-devel mailing list: sword-devel@crosswire.org
> http://www.crosswire.org/mailman/listinfo/sword-devel
> Instructions to unsubscribe/change your settings at above page
_______________________________________________
sword-devel mailing list: sword-devel@crosswire.org
http://www.crosswire.org/mailman/listinfo/sword-devel
Instructions to unsubscribe/change your settings at above page

Reply via email to