Fabien, >> All, >> >> It seems the usage of the environments in config files is inconsistent. >> Since the configuration cache is stored based on environment, is there any >> reason to restrict certain files from not having support for environments? I >> think configuration files like filters.yml and view.yml should be >> customizable based on environment. > > There is no "real" reason. I'm not sure if it makes sense to have > different filters or different view configuration based on environments. > But if there's a need, we can change the behavior. We will then need to > write an update task to ensure a smooth upgrade. >
I will apply this in my branch in the next few weeks. >> >> Also, there is some inconsistency with default/all. Can we change all to >> default for consistency? > > Which inconsistency? default is used in the default config files (and > means the default symfony value) and all means configuration for all > environments. > I meant the inconsistency between a config file supporting environments and not. The difference is petty, but compare cache.yml and app.yml. >> >> Also, what do you think about adding database manager as a factories.yml >> factory? > > That's possible but I don't see a need for this as sfDatabaseManager is > already an abstraction for database management. > >> There is a view_cache factory, but I think we should add a cache >> factory as well (for internal caching apc/xcache/eaccellerator) > > +1 > >> and optimize some parts of the core to use apc/xcache (like caching the path >> lookups for finding templates + configs, or caching routing).. > > +1 if you use the factory which can be sfNoCache. But don't tie symfony > to APC or XCache. Exactly, I would like symfony to automatically use a cache factory if available, otherwise default to sfNoCache. >> >> Also, is it just me or could the web debug timers use a refactor? (they seem >> to always not add up) > > That's "normal". It's an indication of the time required by some layers, > but not symfony layers. > I understand that, I guess I meant the percent timers math is wrong.. I will fix in my branch and merge back. > Fabien > >> >> Any thoughts / questions / concerns? >> >> - Dustin >> >>> >> > > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "symfony developers" group. To post to this group, send email to [email protected] To unsubscribe from this group, send email to [EMAIL PROTECTED] For more options, visit this group at http://groups.google.com/group/symfony-devs?hl=en -~----------~----~----~----~------~----~------~--~---
