Updates: Blockedon: 1520 Comment #36 on issue 1358 by fab...@fseoane.net: (e*f*e*f).subs(e*f,f*e+h) fails if e*f is not commutative http://code.google.com/p/sympy/issues/detail?id=1358
I think patch should be improved. As wflynny says, old method used to put args into a set thus loosing order (important in the non-commutative case). However, If we do subs sequentially I don't think there would be a need to separate commutative and non-commutative parts. I have an algorithm in my head that should make the code much cleaner, but before I proceed I need to have a clear idea on how subs should work. For example, is #33 a bug or not ? Please see also issue 1520 wflynny, you can help me first with issue 1520 looking for example at what other CAS are doing in this case (Maple, Maxima, etc.) and giving your opinion. Then we can improve your patch. -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to sympy-issues@googlegroups.com To unsubscribe from this group, send email to sympy-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en -~----------~----~----~----~------~----~------~--~---