Comment #5 on issue 1495 by asmeurer: minus problem http://code.google.com/p/sympy/issues/detail?id=1495
This looks good, except I am not sure how I feel about right justifying the docstrings. Also, your first commit adds whitespace errors, which it looks like your second commit fixes. You should squash the two commits into one. Just to git rebase -i HEAD~5, which will show you the last 5 commits. Replace the word "pick" in front of your most recent commit with "squash", then save the file. Also, when you try pushing to github, you will need to use the -f flag because you will have rebased. You fixed the other issues I had from your patch in issue 1468, such as whitespace and this problem. It looks like the quartic solver returns a solution a fraction of the size than what it used to (compare solve(x**4 + x**3 + x**2 + x + 1, x) in 0.6.4 and in your branch). So I am +1, other than those things -- You received this message because you are listed in the owner or CC fields of this issue, or because you starred this issue. You may adjust your issue notification preferences at: http://code.google.com/hosting/settings --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-issues" group. To post to this group, send email to sympy-issues@googlegroups.com To unsubscribe from this group, send email to sympy-issues+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-issues?hl=en -~----------~----~----~----~------~----~------~--~---
