Comment #15 on issue 1646 by asmeurer: Solving inequalities
http://code.google.com/p/sympy/issues/detail?id=1646
Yeah, I noticed that you had the same name for test_interval.py as another
existing test. sets.py is a better name,
as there already is a lot more in there than just intervals. The only
thing I would say at this point is to may add a
few more tests for the corner cases. For example, I didn't see any test
for these things that were wrong from prior
comments:
In [26]: a.intersect(b)
Out[26]: 2
Shouldn't this return the singleton {2}, as in either [2, 2] or set([2])?
In [1]: Interval(0, oo) # au should be open. Either raise an exception or
ignore right_open
Out[1]: [0, ∞]
In [6]: Interval(0, I) # This shouldn't be allowed
Out[6]: [0, ⅈ]
You can use the raises() function to test a code block that is supposed to
raise an exception.
Basically, the tests should prevent anyone from breaking any working
functionality if they edit the code, so it
should cover every case. You can also use the coverage tool in ./bin/ to
give you an idea of what code your tests is
not hitting.
Also, like I said, I would like to see what Ondrej thinks of this. I will
ask him on IRC (#sympy) whenever he comes
online, or you can. But with those added tests (assuming they all pass), I
am +1 on this code.
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com
To unsubscribe from this group, send email to
sympy-issues+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---
