Comment #17 on issue 1646 by ondrej.certik: Solving inequalities
http://code.google.com/p/sympy/issues/detail?id=1646

Hi Jorn!

the patches look very good to me, well documented, all tests pass. One last  
thing,
please make sure the doctest coverage tool reports 100% for the  
sympy/core/sets.py:

$ bin/coverage_doctest.py sympy/core/sets.py
----------------------------------------------------------------------
sympy/core/sets.py

Missing documentation:
         * intersect(self, other)
         * complement(self)
         * contains(self, other)
         * measure(self)
         * inf(self)
         * sup(self)
         * intersect(self, other)
         * complement(self)
         * contains(self, other)
         * measure(self)
         * intersect(self, other)
         * complement(self)
         * measure(self)
         * contains(self, other)


Missing doctests:
         * intersect(self, other)
         * inf(self)
         * sup(self)
         * subset(self, other)
         * measure(self)
         * start(self)
         * end(self)
         * left_open(self)
         * right_open(self)

SCORE sympy/core/sets.py: 11% (3 of 26)
----------------------------------------------------------------------


as you can see, currently it reports 11%. You know the best how to put  
there couple
examples showing how the methods work.

After that, it's +1 from me. Thanks for working on this, it's a very nice  
contribution.

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

--~--~---------~--~----~------------~-------~--~----~
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-issues@googlegroups.com
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en
-~----------~----~----~----~------~----~------~--~---

Reply via email to