Updates:
        Labels: -NeedsReview NeedsBetterPatch

Comment #6 on issue 2014 by asmeurer: sympy.solvers.solvers.solve should also allow frozenset to hold equations
http://code.google.com/p/sympy/issues/detail?id=2014

You should add tests. There at least needs to be a test for frozenset working for solve (since that is the point of the issue). Tests for iterable containers working in the new places that didn't work before would be nice too, though I wouldn't mind not having them (what are others' opinions?).

I think it is unnecessary and unPythonic to do

if not hasattr(seq, '__iter__'):
    raise TypeError("Not an iterable container")

because the very next line

for i in seq:

will raise the exact same error. It is like this in at least Basic._subs_dict, Basic._subs_list, and plotting/color_scheme.py, but maybe it is also so in other places too. Actually, for that last one, it raises some v_error which doesn't seem to ever be defined, so that should probably be fixed and tested.

--
You received this message because you are subscribed to the Google Groups 
"sympy-issues" group.
To post to this group, send email to sympy-iss...@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-issues+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-issues?hl=en.

Reply via email to