Ondrej Certik wrote: > On Thu, Aug 13, 2009 at 7:05 AM, Vinzent > Steinberg<vinzent.steinb...@googlemail.com> wrote: >> I'd prefer >> >> """Handler for the absolute value.""" >> >> (see PEP 257 [1]) over >> >> """handler for the absolute value""" >> >> but that's certainly not important. After all, most docstrings in sympy are >> not conforming to all these conventions. >> You could still leave the old information (before you made the docstrings >> consistent) there if you want. >> >> I'm not sure about putting all the logic in __init__.py. Isn't it supposed >> to have only the imports? > > There are no doctests for the functions in the refine module, and also > I would not use "from sympy import *", but rather import thigs > explicitely. So I will have to fix it at some point in the future, so > I would prefer if you could do that now. :)
All methods that are part of the user interface have docstring and doctests. I just see little benefit for making doctest for methods that are used internally (refine_Pow, refine_abs, etc.) I prefer to import * in the examples than "from sympy import Q, Symbol, Assume, sqrt, refine". After all, users will end up typing this in the terminal. > > Otherwise +1. > > Ondrej > > > --~--~---------~--~----~------------~-------~--~----~ You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patches@googlegroups.com To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en -~----------~----~----~----~------~----~------~--~---