Nice, Ondrej! Thanks for spending time on this! I remember at one point implementing a trivial .doit() to prevent a crash further up. I was not that familiar with the code at the time, so I didn't want to mess around with the core. It should ideally be removed.
Øyvind sø., 29.11.2009 kl. 19.47 -0800, skrev Ondrej Certik: > Ok, I spent several hours today writing doctests for it. I increased > the coverage from 44% to 59%. I think most of the methods are > documented now, but there are still some that are not, but those are > mostly things like eval(). I don't have time to finish it, but since > everyone seems to agree, I pushed it in. > > What is the purpose of the doit() methods? They just return self and > there is no comment/docstring at all. Should they be removed? > > Ondrej > > On Mon, Nov 23, 2009 at 3:32 PM, Ondrej Certik <ond...@certik.cz> wrote: > > On Mon, Nov 23, 2009 at 3:15 PM, Øyvind Jensen <jensen.oyv...@gmail.com> > > wrote: > >> The failed assertion X<Y<Z should simply be removed. It fails because > >> of the platform-dependent hash, and is not relevant any more. > >> > >> It used to be relevant when I tried to use the relation > >> > >> [[A,B],C] + [[C,A],B] + [[B,C],A] = 0 > >> > >> to enforce a canonical nesting of commutators. I couldn't get it to > >> work properly, so I removed it but forgot to remove that test. Some > >> sort of canonical nesting of Commutators would be cool... > > > > Ok, cool. > > > > Ondrej > > > > -- > > You received this message because you are subscribed to the Google Groups > "sympy-patches" group. > To post to this group, send email to sympy-patc...@googlegroups.com. > To unsubscribe from this group, send email to > sympy-patches+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy-patches?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
