> why did you remove the following tests (sympy/core/tests/test_arit.py): > > - assert list((I*pi).atoms(NumberSymbol)) == [pi] > - assert sorted((I*pi).atoms(NumberSymbol, I)) == \ > - sorted((I*pi).atoms(I,NumberSymbol)) == [pi, I]
There must be a better way to find this...sorry, I can't find where this was removed from arit, but I do see that these lines are in test_basic. > - assert (Rational(1,2)*x).extract_multiplicatively(3) == x/6 The new behavior is that multiplicative extractions allow things that make the expression move towards 1. You can extract 2/3 from 4/9 but you can't take 3 from 1/2 since this moves you toward 0, not 1. > - assert (x**(Rational(1,2))).extract_multiplicatively(1/x) == > x**(Rational(3,2)) The same thing applies here...the exponent is going *past* 1. It must approach 1. You can take x**(1/2) from the above or x**(1/4) but not 1/ x. > -def test_coeff_expand(): > - x, y, z = symbols('x y z') > - expr = z*(x+y)**2 > - expr2 = z*(x+y)**2 + z*(2*x + 2*y)**2 > - assert expr.coeff(z) == 2*x*y + x**2 + y**2 > - assert expr.coeff(z, expand=False) == (x+y)**2 > - assert expr2.coeff(z) == 10*x*y + 5*x**2 + 5*y**2 > - assert expr2.coeff(z, expand=False) == (x+y)**2 + (2*x + 2*y)**2 It has a new behavior as explained in commit 1835's log. > I will try to find this out from your patches, maybe it's explained in > the log. Otherwise, it looks good, all tests pass. I need to figure > out the above and then also run benchmarks, because some core stuff > was modified. Then it's ready to be pushed in. I guess the pieces that I would prefer to wait on are the quartz and related commits after it that don't have numbers; and the equal and ode related functions that were used to test for equality of expressions. I would like to merge the ideas contained in the ode's helpers and the equal() routine (which is now camping in simplify/ __init__.py as I recall). -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.