On Thu, Jun 17, 2010 at 8:19 AM, Christian Muise <christian.mu...@gmail.com> wrote: > So the main problems start to crop up when you start stripping out > assumptions from the constructor of basic sympy objects. This breaks > compatibility, and very quickly the number of errors goes up. You can view > the natural progression of what you suggest on this branch: > - http://github.com/haz/sympy/commits/disconnect-assumptions-2 > Up to this commit, errors are fixed up and things go from 293 passed, 17 > failed, 20 exceptions down to 300 passed, 22 failed, 8 exceptions: > - http://github.com/haz/sympy/commit/d25877c0998bda73033a16b30b12494c53da6eec > -- Note, even though that last commit removes an entire test suite, it only > saves you a single exception -- the other commits contribute a lot. > Now when you start to remove the assumptions argument to the constructor > of Symbol, via this commit, things start to rear their ugly head: 291 pass, > 11 fail, 27 exceptions: > - http://github.com/haz/sympy/commit/f8e4e04f6f92b54f777f624a8840ed5dd3571b8c > So I think the reason the first attempt looks so bad (77 exceptions), is > because I've gone deeper into removing the assumptions from the constructors > of various sympy objects. I would expect to see the same when I continue > down this second attempt (that is without the predicate stuff, the > Application class, etc). > Hopefully this sheds some light on the issues I'm facing. Feedback on the > commits in dissconnect-assumptions-2 would be great to have.
I see now. So the direction that I would take is: take the commit d25877c and fix the rest of the 30 failing tests. Any idea why they fail? Only 30 tests is not bad, that should be possible to fix. I would save removing the assumptions argument as the next step, only after all commits pass, as it seems to introduce a lot new problems. Is there any other alternative? If you agree, let's get this finished. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
