On Thu, Jun 17, 2010 at 12:27 PM, Christian Muise <christian.mu...@gmail.com> wrote: > Ondrej, if you could provide feedback on these two commits, it would really > help: > - http://github.com/haz/sympy/commit/91bcb155b24fd354cfdc3b765823ba5041412dce > - http://github.com/haz/sympy/commit/f0c8becedc87b324f293baea159a73c4057a9a3a
That looks ok to me, except that I don't like to use global assumptions, not even in tests. But let's get things running for now, and fix these issues later. > Specifically in the last one, this is something I didn't change anything > for, but the test case itself: > - assert Real(7.7).epsilon_eq(abs(x).subs(x, -7.7)) > + assert Real(7.7).epsilon_eq(abs(x.subs(x, -7.7))) > Is abs(x) supposed to not evaluate the abs right away or something? I > don't know how that test was passing before... Imho you should keep both ways (both the "+" and "-" lines above). The abs(x) should remain as the abs() function in sympy, and .subs() just tests, that it works fine. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
