On Tue, Jun 29, 2010 at 5:10 PM, Øyvind Jensen <jensen.oyv...@gmail.com> wrote: > ti., 29.06.2010 kl. 11.26 -0700, skrev Matt Curry: >> Hello, >> >> I've been working on implementing Hilbert spaces in SymPy. I have >> created/improved two files located on my github account: >> >> hilbert.py: >> http://github.com/mattcurry/sympy/blob/hilbert/sympy/physics/hilbert.py >> test_hilbert.py: >> http://github.com/mattcurry/sympy/blob/hilbert/sympy/physics/tests/test_hilbert.py >> >> They are rebased and ready to go; please review them to see if >> anything needs to be changed. >> >> Thanks, >> >> Matt Curry >> > > Hello Matt, > > I just had a quick glance, and I think it looks very good! I'll see if > I can find time to review it properly tomorrow. I've got two questions > already, though: > > 1) Do you really need to overload _eval_subs(old, new)? As far as I can > see, your implementations do not differ from what you should get by just > leaving it to Basic._eval_subs().
I think you are right, but Matt should check this with tests. > 2) (A more general question) What is the plan for how the framework will > be used in practical calculations? Specifically, have you figured out > what will be the relation between the hilbert spaces and the elements > that populate them? Lets say you have a 1-d function representing the > ground state of a square well, how will you connect that function with > your framework? Inheritance?, aggregation?, assumptions? etc. The main thing that hilbert spaces will allow is for different operations to make sure that elements belong the the right hilbert space. For examples, to do operator application, inner products, etc., we need to make sure the underlying hilbert spaces are compatible. That is the main purpose of having them. Most of that will be done using HilbertSpace.__contains__. > I am asking because I am implementing an Indexed class as part of my > project, and eventually I'd like them to interact with your framework. > If that works out, we can generate all kinds of QM equations in an > abstract matrix representation. What will the indexed class do and how does it differ from sympy.Matrix? Matt is about to start working on representation theory, so it might be good to keep you in the loop. Cheers, Brian > Cheers, > > Øyvind > > -- > You received this message because you are subscribed to the Google Groups > "sympy-patches" group. > To post to this group, send email to sympy-patc...@googlegroups.com. > To unsubscribe from this group, send email to > sympy-patches+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy-patches?hl=en. > > -- Brian E. Granger, Ph.D. Assistant Professor of Physics Cal Poly State University, San Luis Obispo bgran...@calpoly.edu elliso...@gmail.com -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
