On Tue, Jul 27, 2010 at 9:11 AM, Andy Ray Terrel <andy.ter...@gmail.com> wrote: > On Tue, Jul 27, 2010 at 10:33 AM, Toon Verstraelen > <toon.verstrae...@ugent.be> wrote: >> On 07/26/2010 10:36 PM, Ųyvind Jensen wrote: >>> >>> I have uploaded my work on the C code printer, C code generator and the >>> tensor module to smartbear for review: >>> >>> http://hosted.smartbear.com/sympy/go?page=ReviewDisplay&reviewid=6 >>> >>> The ability to create code that loops over array arguments is much >>> improved, mainly because the contraction logic is now handled in the >>> tensor module. I added Andy as reviewer, but anyone can add themselves >>> to the review to be able to create comments and defects. >>> >>> The code is also on github: >>> http://github.com/jegerjensen/sympy/tree/codegen_C2 >> >> I've just tried Smartbear. It is a neat thing. Compared to Github it gives a >> better overview of all the comments, and it has better possibilities for the >> follow-up of comments. The user interface of Smartbear is a bit >> overcomplicated though, with much more features than we need. (e.g. I >> accidentally clicked the accept button here and there because I wanted to >> figure out its meaning. Please ignore it.) >> >> Github seems to be a more open system, with a real commitment to supporting >> communities. I have a different feeling about SmartBear. Will they keep >> running the demoserver for free once we get used to it? Is it clear under >> which conditions it will keep working for us? >> > > If Github had more code review capabilities I would be more inclined > to use it for code reviews. But as is, it is hard to find all the > comments, know when someone responded to a comment, and figure out > when a defect in the review is fixed. These are things that all code > review systems do. > > Github's comments and users are more open but it is still a closed > system controlled by a company. I don't know that SmartBear is any > more apt to pull the rug out from under us than GitHub is. It is also > a pay/shareware system and it could go the way of BitKeeper anytime. > SmartBear runs several of these hosted systems but is willing to just > give us a license and let us host it if we like. If we want a system > that is committed to open source and is truly open, we should use > launchpad. > > I think it would be better to stick to one system per review. Having > to switch between github and smartbear to find all the comments is > just a waste of time. We can keep both systems running and let the > submitter pick the review mechanism. The smartbear system is working > well for Øyvind and I but perhaps if at the end of the summer nobody > else wants it we can discard it then.
I'll give smartbear another shot. I agree with your comments (both Toon's and yours). Ondrej -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.
