2010/8/15 Christian Muise <christian.mu...@gmail.com> > > Vinzent: Thank you for picking through it all. I've fixed everything you > mentioned, and just included an update with new comments / docstrings (a > common thread of feedback you had).
Thanks, this is much better. Doctests would be great, but I think the solver is rarely ever exposed to the user, so this is probably low priority. Escaping newlines is not necessary if you got parentheses, for example in And( \ Or(Not(Q.integer), Q.even, Q.odd), \ Or(Not(Q.extended_real), Q.infinity, Q.real), \ Or(Not(Q.real), Q.irrational, Q.rational), \ [...] ) you can drop every '\'. > > Branch: http://github.com/haz/sympy/tree/soc-final-fixed > Docstring > Commit: http://github.com/haz/sympy/commit/9af23ff2bdf720999789d988d94cd36c9dc53b0f > Let me know if there's anything else that should be fixed up. Thanks again. Did you rebase some commits in your branch? Or is there just the new commit? Vinzent -- You received this message because you are subscribed to the Google Groups "sympy-patches" group. To post to this group, send email to sympy-patc...@googlegroups.com. To unsubscribe from this group, send email to sympy-patches+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy-patches?hl=en.