Updates:
Owner: pr...@goodok.ru
Labels: -NeedsReview NeedsBetterPatch
Comment #23 on issue 821 by Vinzent.Steinberg: multiple arguments for max
and other improvements
http://code.google.com/p/sympy/issues/detail?id=821
Thanks, this looks good, the code works as it should and the tests pass. I
made a few suggestion about the documentation on github.
I just noticed this:
In [10]: Max(I,1,zoo)
Out[10]: Max(1, zoo, ⅈ)
This is not related to this patch, but we should probably also check that
the input is always "real".
Removing 'nargs' is fine. I'm not sure about "evaluate=False", but I don't
know another easy way. Maybe calling __new__ directly?
"@classmethod" is only intended if your method does not need an instance.
Consider
Max.method
vs.
x = Symbol('x')
Max(1,x).method
So in your case the use of this decorator is fine (you are operating
on 'cls' and not 'self').
--
You received this message because you are subscribed to the Google Groups
"sympy-patches" group.
To post to this group, send email to sympy-patches@googlegroups.com.
To unsubscribe from this group, send email to
sympy-patches+unsubscr...@googlegroups.com.
For more options, visit this group at
http://groups.google.com/group/sympy-patches?hl=en.
