Updates:
        Labels: -NeedsBetterPatch NeedsReview

Comment #24 on issue 821 by pr...@goodok.ru: multiple arguments for max and other improvements
http://code.google.com/p/sympy/issues/detail?id=821

Thanks a lot for detailed and useful remarks here and there!

I have updated the pull now.

Regarding the comparison of incomparable arguments.
I consider them as unjoined vertexes, for generalization in common case: whether they have boolean relation or not (`is_connected` method). Besides, by that I move the problem and tuning of Max behaviour to `>`, `==`, `<` operators in SymPy core.

What to do with concrete comparison of complex number I don't know. I think that complex numbers comparable only by norm, but user can tune it manually, supplying appropriate arguments.

At the same Max can consider as ordinary unevaluated expression, e.g.

Max(cos(x), sin(x))
Max(cos(x), sin(x))

with the aim to further

Max(cos(x), sin(x)).subs(x, 0)
1

For this aim I should not like the checking of inputs for "real".

And also, I've forgotten to notice it in previous message, in one place (`def remove_duplicates`) I used python 2.5 technique, guided by [1].

Is it acceptably for next milestone?

[1] http://docs.python.org/faq/programming.html#how-do-you-remove-duplicates-from-a-list

--
You received this message because you are subscribed to the Google Groups 
"sympy-patches" group.
To post to this group, send email to sympy-patches@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-patches+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-patches?hl=en.

Reply via email to