Updates:
        Labels: -NeedsBetterPatch NeedsReview

Comment #19 on issue 2308 by asmeurer: Should we rename primitive()? (and Expr.primitive() should call primitive())
http://code.google.com/p/sympy/issues/detail?id=2308

OK, I updated the branch at https://github.com/sympy/sympy/pull/322 to just make Expr.primitive() a shortcut function for primitive(), just like we have for simplify(), factor(), and others. The tests for Add.primitive were just equalities without assertions (issue 2432), so some of them were wrong (!) Everything has been fixed.

Regarding a name change, if Mateusz things it should be changed, let's do it. Otherwise, I think primitive() is fine. It wouldn't be the first name in SymPy that means something different from what someone might initially think.

--
You received this message because you are subscribed to the Google Groups 
"sympy-patches" group.
To post to this group, send email to sympy-patches@googlegroups.com.
To unsubscribe from this group, send email to 
sympy-patches+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/sympy-patches?hl=en.

Reply via email to