Hello Aaron ! I have a working patch with me. I've set up my Git account. I need help with how to add my patch to SymPy. I've forked SymPy but 'blindly'. Can't understand how it works. Please tell me how to send the patch to you.
I've added the functions fastR, fastC, transpose and the properties FR,FC,T to the SMatrix class. It is successfully transposing a SMatrix. the fastR function returns a Row-sorted list of non-zero elements, and similarly for fastC I'll attach the matrices.py here also, for reviews. Thanks, Sherjil Ozair On Mar 19, 3:25 pm, "Aaron S. Meurer" <asmeu...@gmail.com> wrote: > Sounds good. Let us know if you need help making the patch using git. > > Aaron Meurer > > On Mar 19, 2011, at 4:03 AM, SherjilOzair wrote: > > > > > > > > > Thank you, > > I've been reading the Matrices class. > > > The SMatrix class borrows its transpose, determinant and mult > > functions from Matrix, and thus is inefficient for Sparse Matrices. > > > The transpose doesn't even work for SMatrix. > > >>>> a=SMatrix(10,10,lambda i,j:isprime(i)) > >>>> a.T > > Traceback (most recent call last): > > File "<console>", line 1, in <module> > > File "sympy/matrices/matrices.py", line 187, in transpose > > a[i*self.rows:(i+1)*self.rows] = self.mat[i::self.cols] > > TypeError: unhashable type > > > I intend to correct this bug. I have coded in another representation, > > which is basically a list of all non-zero elements. > > I'll edit the transpose method in SMatrix to make use of this > > representation for efficiency. > > > I will correct the bug too and make room for increase in efficiency in > > SMatrix methods by using the alternate representation. > > > This will be my easy patch, and my first contribution to Sympy. > > Any suggestions ? > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To post to this group, send email to sympy@googlegroups.com. > > To unsubscribe from this group, send email to > > sympy+unsubscr...@googlegroups.com. > > For more options, visit this group > > athttp://groups.google.com/group/sympy?hl=en. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
