On Tue, Apr 5, 2011 at 11:07 AM, Brian Granger <elliso...@gmail.com> wrote: > I am +1 on this plan. > > Brian > > On Tue, Apr 5, 2011 at 9:59 AM, Ondrej Certik <ond...@certik.cz> wrote: >> Hi, >> >> I have talked with Mateusz over a dinner last Sunday, and Aaron over >> the phone, and also Ronan over the phone just now, and we discussed >> what has to be done to merge this branch, and I think we are all on >> the same page, and want to get this merged as soon as possible. Now >> the only question is to setup a plan and do it. >> >> >> So I wanted to share the results from our call with Ronan today, and >> ask everyone for feedback: >> >> 1) We should release before the merge, because it's a huge branch, and >> we shouldn't be pressured by the release to fix things in master, we >> should simply release what we have, which is well tested, and then >> merge the polys
Is Mateusz +1 on this? polys12 fixes a lot of bugs in master that were introduced with the original merge of the new polys. For example, all of these (http://code.google.com/p/sympy/issues/list?can=2&q=label%3ANeedsReview+owner%3Amattpap%40gmail.com+&colspec=ID+Type+Status+Priority+Milestone+Owner+Summary+Stars&cells=tiles). I would argue that polys12 *has* been tested because every time something polys related fails in master we check it in polys12 (and usually it works there). Also, I have been working off of Mateusz's work all summer, so at least the older commits have been well used by me. Also, aren't there some backwards compatibility breaks in polys12 that aren't in master? If that's the case, we should consider merging before the 0.7.0 release. I'd say we have about as many things to do for the release from master as we do for polys12 (see the milestone0.7.0 and priority-critical issues), so it might be worth it to try to get polys12 in before the release (also, I really don't want to postpone it any further; I think Mateusz will agree). Aaron Meurer >> >> 2) Merge the branch as it is >> >> 3) Fix the rest of the things in master. The things to fix are (at >> least): sympy/core/exprtools.py (it might be moved somewhere else, >> after discussion), lambda issue (Ronan said he has some code to fix >> this), and RootOf issue (I think Mateusz told me, that he would help >> with this, once things are merged) >> >> 4) Fix the things in 3) before the next release >> >> The above plan would be ok with Ronan, and is definitely ok with me. >> Would that be ok with you Mateusz and Aaron (and Chris, and everybody >> else) as well? I will help with the release, so that it's done, and we >> can merge this in. >> >> Ondrej >> >> -- >> You received this message because you are subscribed to the Google Groups >> "sympy" group. >> To post to this group, send email to sympy@googlegroups.com. >> To unsubscribe from this group, send email to >> sympy+unsubscr...@googlegroups.com. >> For more options, visit this group at >> http://groups.google.com/group/sympy?hl=en. >> >> > > > > -- > Brian E. Granger > Cal Poly State University, San Luis Obispo > bgran...@calpoly.edu and elliso...@gmail.com > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sympy@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
