On Mon, Apr 25, 2011 at 4:37 PM, Aaron S. Meurer <asmeu...@gmail.com> wrote: > On Apr 25, 2011, at 5:12 PM, Ondrej Certik wrote: > >> On Mon, Apr 25, 2011 at 12:59 PM, Aaron S. Meurer <asmeu...@gmail.com> wrote: >>> >>> On Apr 25, 2011, at 1:54 PM, Tom Bachmann wrote: >>> >>>> Dear list, >>>> >>>> I would like to open a discussion on how to merge my (fairly >>>> extensive) fixes to the gruntz algorithm. As far as I understand >>>> release is currently top priority, so merging a large change might >>>> seem a no-go (and I shall not assume to know better ^^), but I think >>>> shipping quite badly broken code is not very satisfying either. Let me >>>> press on under the working assumption that there is interest of >>>> getting this in quickly. >>> >>> It is top priority, but we are still in the "Fix release blocking issues" >>> phase, i.e., we need to close all of these issues: >>> http://code.google.com/p/sympy/issues/list?can=2&q=Milestone%3DRelease0.7.0&colspec=ID+Type+Status+Priority+Milestone+Owner+Summary+Stars&cells=tiles >>> (note that quite a few of these are already closable due to the polys12 >>> merge). So you can still squeeze it in. >>> >>> Does anyone here know how the Gruntz algorithm works, other than Ondřej? >>> And do I understand it correctly that it is only [3] that would require >>> knowledge of it, or does [2] as well? >> >> >> I am ready to explain any parts, that are not clear, and improve docs >> for it, if needed. Just ask me, what is not clear. >> >> Ondřej > > I meant is there anyone else here who understands it who can help review his > branch? It would be best if someone with familiarity with the algorithm > could review it, since he made some fundamental changes to the algorithm.
I reviewed the changes to gruntz.py, those are fine, except my two little questions asked in the pull request. Ondrej -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
