On Tue, Jun 7, 2011 at 4:01 AM, Aaron Meurer <asmeu...@gmail.com> wrote:
> Yes, make a pull request (though I can already see problems with your > code, like whitespace errors and that you need to wrap the text in > your docstrings). > > Aaron Meurer > > I made the pull request (#390) and I will be thankful if anyone pin-point where I need to improve the code, > On Mon, Jun 6, 2011 at 3:06 PM, Hector <hector1...@gmail.com> wrote: > > > > > > On Tue, Jun 7, 2011 at 1:04 AM, Aaron S. Meurer <asmeu...@gmail.com> > wrote: > >> > >> On Jun 6, 2011, at 10:44 AM, Hector wrote: > >> > >> > >> On Tue, Mar 29, 2011 at 5:42 AM, Mateusz Paprocki <matt...@gmail.com> > >> wrote: > >>> > >>> Hi, > >>> > >>> On 28 March 2011 16:40, Aaron S. Meurer <asmeu...@gmail.com> wrote: > >>>> > >>>> If this is implemented anywhere, it would be on the polys module. So > I > >>>> would check there. I don't remember off the top of my head right now > if it > >>>> has been implemented or not. > >>> > >>> It's not implemented, but all necessary tools are in galoispolys.py. > The > >>> algorithm itself is described in one of books that were mentioned in > this > >>> module's docstrings. > >>> > >>>> > >>>> Aaron Meurer > >>>> > >>>> On Mar 28, 2011, at 1:06 AM, Hector wrote: > >>>> > >>>> > Hello ppl, > >>>> > > >>>> > I was browsing the code and realized that some of my earlier written > >>>> > codes can be implemented if they are already not present. So I > started to > >>>> > dig more but couldn't find any function for solving f(x) congruent > to 0 mod > >>>> > (n). Does any function exists in SymPy to solve this? If yes, where > is it? > >>>> > If no, where can I add this function? > >>>> > > >>>> > > >>>> > -- > >>>> > -Regards > >>>> > Hector > >>>> > > >>>> > Whenever you think you can or you can't, in either way you are > right. > >>>> > > >>>> > > >>>> > -- > >>>> > You received this message because you are subscribed to the Google > >>>> > Groups "sympy" group. > >>>> > To post to this group, send email to sympy@googlegroups.com. > >>>> > To unsubscribe from this group, send email to > >>>> > sympy+unsubscr...@googlegroups.com. > >>>> > For more options, visit this group at > >>>> > http://groups.google.com/group/sympy?hl=en. > >>>> > >>>> -- > >>>> You received this message because you are subscribed to the Google > >>>> Groups "sympy" group. > >>>> To post to this group, send email to sympy@googlegroups.com. > >>>> To unsubscribe from this group, send email to > >>>> sympy+unsubscr...@googlegroups.com. > >>>> For more options, visit this group at > >>>> http://groups.google.com/group/sympy?hl=en. > >>>> > >>> > >>> Mateusz > >>> -- > >>> You received this message because you are subscribed to the Google > Groups > >>> "sympy" group. > >>> To post to this group, send email to sympy@googlegroups.com. > >>> To unsubscribe from this group, send email to > >>> sympy+unsubscr...@googlegroups.com. > >>> For more options, visit this group at > >>> http://groups.google.com/group/sympy?hl=en. > >> > >> Hello falks, > >> > >> Apologies for the long silence. > >> I wrote a function gf_csolve and necessary sub-functions to compute > it[0]. > >> This looks fine till now and I am ready to open a pull request expect > the > >> fact that I am not able to use gcdex ( line nos 2037-2038) if I declare > it > >> at the starting of file or anywhere outside the function > linear_congruence. > >> I face similar problem with ZZ. I am unable to use it in > >> sympy/polys/galoistools.py > >> > >> Thank you for any suggestions. And as I am currently working in number > >> theory, I would like to know is there any other function in number > theory > >> that can be added to sympy. > >> > >> -- > >> -Regards > >> Hector > >> Whenever you think you can or you can't, in either way you are right. > >> [0] > >> > https://github.com/hector1618/sympy/commit/6ade183e72aea76d579c9a9460e00eee35802a1b > >> > >> If I understand you correctly, this is a circular import problem, and > just > >> importing it from within the function is the correct solution. > >> Aaron Meurer > > > > Does this mean that calling it from the function is the only choice we > have? > > If it is so, can I go ahead and make a pull request? > > > >> > >> -- > >> You received this message because you are subscribed to the Google > Groups > >> "sympy" group. > >> To post to this group, send email to sympy@googlegroups.com. > >> To unsubscribe from this group, send email to > >> sympy+unsubscr...@googlegroups.com. > >> For more options, visit this group at > >> http://groups.google.com/group/sympy?hl=en. > > > > > > > > -- > > -Regards > > Hector > > Whenever you think you can or you can't, in either way you are right. > > > > -- > > You received this message because you are subscribed to the Google Groups > > "sympy" group. > > To post to this group, send email to sympy@googlegroups.com. > > To unsubscribe from this group, send email to > > sympy+unsubscr...@googlegroups.com. > > For more options, visit this group at > > http://groups.google.com/group/sympy?hl=en. > > > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To post to this group, send email to sympy@googlegroups.com. > To unsubscribe from this group, send email to > sympy+unsubscr...@googlegroups.com. > For more options, visit this group at > http://groups.google.com/group/sympy?hl=en. > > -- -Regards Hector Whenever you think you can or you can't, in either way you are right. -- You received this message because you are subscribed to the Google Groups "sympy" group. To post to this group, send email to sympy@googlegroups.com. To unsubscribe from this group, send email to sympy+unsubscr...@googlegroups.com. For more options, visit this group at http://groups.google.com/group/sympy?hl=en.
