Thank you for your mail Sir Oscar Benjamin, As a new contributor I was having difficulty after making a pull request authors check failed but then after observing the details I have done these things
--> Before editing .mailmap, I run the command bin/mailmap_update.py --> then made entry to .mailmap as Name <global git email> --> then re-run bin/mailmap_update.py --> run bin/authors_update.py --> git commit -am 'Update .mailmap/AUTHORS. Welcome to Sympy!' Are these things correct? And will that check pass afterwards or I will have to make the pull request again? On Wed, 26 Jan, 2022, 3:58 am Oscar Benjamin, <oscar.j.benja...@gmail.com> wrote: > On Tue, 25 Jan 2022 at 22:20, Jeremy Monat <jemo...@gmail.com> wrote: > > > > Thanks, Oscar. What do existing contributors need to do? > > Nothing if the name is already recorded in .mailmap: > > https://github.com/sympy/sympy/blob/b9b33b424f63727f57e5277bfc6fc8a6619d0cdf/.mailmap#L546 > > https://github.com/sympy/sympy/blob/b9b33b424f63727f57e5277bfc6fc8a6619d0cdf/AUTHORS#L1130 > > If any existing contributors can see duplicate names for themselves > either in .mailmap or AUTHORS then they should say so and I'll resolve > it: > > I already added every name to .mailmap that wasn't there yet. New > contributors will need to add themselves to .mailmap before their > first PR can be merged though. > > -- > Oscar > > -- > You received this message because you are subscribed to the Google Groups > "sympy" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to sympy+unsubscr...@googlegroups.com. > To view this discussion on the web visit > https://groups.google.com/d/msgid/sympy/CAHVvXxRe0V7fTc91dKrAgBZb0qv81dP3_UvPgTqajd6zinAT%3DA%40mail.gmail.com > . > -- You received this message because you are subscribed to the Google Groups "sympy" group. To unsubscribe from this group and stop receiving emails from it, send an email to sympy+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/sympy/CAEBjiXdE9kh%3Dwo3DhgG_tQZ%2B9s7WZm9Z65ExXCrxrb1rdh%3D07g%40mail.gmail.com.
