Re: Proposal to combine the Inline script mediator with the Script mediator

[Asankha C. Perera]

Hi Ant Kasun has attached the patch to a JIRA here https://issues.apache.org/jira/browse/SYNAPSE-67 for review If you are unable to apply the patch, let me know and I will send you a tar of the changed classes. I had a lot of problems myself with the patch being incompatible between Kasuns system and mine (some hunk errors) - possibly due to some crazy line ending issues - even though both systems are Ubuntu and uses the same version of SVN.. Here is a list of the changes - note the deleted files. M      modules/extensions/src/test/java/org/apache/synapse/mediators/AbstractTestCase.java M      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/GroovyScriptMediatorTest.java M      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorFactoryTest.java M      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/convertors/JSOMElementConvertorTest.java M      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorSerializationTest.java D      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/InlineScriptMediatorTest.java M      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMediatorTest.java D      modules/extensions/src/test/java/org/apache/synapse/mediators/bsf/ScriptMessageContextTest.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediatorFactory.java D      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/InlineScriptMediatorSerializer.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediatorSerializer.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/JSOMElementConvertor.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/OMElementConvertor.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/RBOMElementConvertor.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/DefaultOMElementConvertor.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/convertors/GROOVYOMElementConvertor.java D      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/InlineScriptMediator.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMediator.java D      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ThreadLocalMessageContext.java M      modules/extensions/src/main/java/org/apache/synapse/mediators/bsf/ScriptMessageContext.java M      modules/extensions/src/main/resources/META-INF/services/org.apache.synapse.config.xml.MediatorSerializer M      modules/extensions/pom.xml M      pom.xml thanks asankha Asankha C. Perera wrote: Hi Ant Yes this will go into 1.0 RC1 and is complete, and I was just helping out Kasun with a code review today. This would be attached to the JIRA tomorrow and you could verify and commit after review. thanks asankha ant elder wrote: How are you getting on with this, are you still planing on looking at it? Is there anything I could do to help? Or take it one if you don't have time to do it now? Be good to try to get it done in time for the 1.0 release.    ...ant On 2/22/07, Kasun Samarasinghe <[EMAIL PROTECTED]> wrote: Hi Currently Synapse supports two variants for script mediation, where the script could be specified through a property or inline. E.g. <set-property name="prop" src=""/> in mediation <script key="prop" function="mediation_function"/> In line mediators where we specify the script type in it self as LL E.g. <script.LL><![CDATA[           some script...... ]]></script.LL> I think these could be combined into one single script mediator.  Also, I think its better to explicitly specify the script language, as guessing the language when the script is specified by a property may not always be reliable. So the suggestion is E.g <script type="LL" [key="prop"] [function="mediation_function"]>         <![CDATA[.. inline script ..]]>? </script> What do you think? I would be happy to raise a jira and submit a patch for this enhancement thanks kasun --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]