On 3/15/07, Asankha C. Perera <[EMAIL PROTECTED]> wrote:
Hi Ant > No it doesn't apply correctly for me either sorry, can't see exactly > why yet, so if you have a zip then attaching that to the jira would be > helpful. The changes look fine to me though so if you already have it > applied locally feel free to just commit it. I committed this change, as I spent quite a bit of time trying to troubleshoot it myself.. I have reviewed the code, but would be great if you could go through as well. The main concern I have is whether BSFEngines are threadsafe. Check ScriptMediator.loadBSFEngine() and the comment I have made. If the engine is not thread safe we should synchronize access to it..
The best way to resolve this is to use JSR-223 instead of Apache BSF v2 as JSR-223 script engines have an API to see if the engine is threadsafe. BSF version 3 is implementing JSR-223 and there's a beta1-SNAPSHOT available now but no proper release yet. I would have quite liked Synapse 1.0 to use BSF v3 but didn't want to get in the way of the release. We probably could get a BSF v3 beta1 release out quite quickly if Synapse said it would use it. Is there an interested in doing that? ...ant
